ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
464 stars 618 forks source link

Alttp: assert failures in fill_restrictive #924

Closed black-sliver closed 1 year ago

black-sliver commented 2 years ago

The following locations (maybe more) have rules that depend on state:

When filling in fill_restrictive we check with maximum_exploration_state but in push_item we assert with self.state, which seems to be different and fail the assertion. This accounts for quite a few generation failures in my random-yaml testing, so this should probably be fixed. Ping me on discord if you need a reproducer, but I'm pretty sure the difference in state is what makes it crash.

Berserker66 commented 1 year ago

@espeon65536

Berserker66 commented 1 year ago

presumed fixed with https://github.com/ArchipelagoMW/Archipelago/pull/1702