ArdanaLabs / DanaSwapUI

Other
3 stars 3 forks source link

Reassess usage of vendor prefixes in CSS styles #28

Open toastal opened 2 years ago

toastal commented 2 years ago

I see -webkit-background-clip, but support shows (https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip) that it has worked without prefixes for a long time now. Scrollbars can also be styled in Firefox unprefixed. Assuming Autoprefixer is in the project, it's highly likely that all vendor prefixes could be skipped. It's better to cover all browsers than limit ourselves to Webkit when possible.

Example:

$ rg "\-webkit-" frontend-dashboard/src/                                                                                                                                                            DanaSwapUI 
frontend-dashboard/src/theme.ts
607:            "-webkit-linear-gradient(121.21deg, #1EFF78 -11.78%, #5294FF 118.78%)",
608:          "-webkit-background-clip": "text",
609:          "-webkit-text-fill-color": "transparent",
1182:            "-webkit-linear-gradient(121.21deg, #1EFF78 -11.78%, #5294FF 118.78%)",
1183:          "-webkit-background-clip": "text",
1184:          "-webkit-text-fill-color": "transparent",

frontend-dashboard/src/pages/Launch/sections/partialstats.section.tsx
39:    //   background: "-webkit-linear-gradient(-90deg, #FFFFFF, #ffffff00)",
40:    //   "-webkit-background-clip": "text",
41:    //   "-webkit-text-fill-color": "transparent",
44:    //   background: "-webkit-linear-gradient(90deg, #FFFFFF, #ffffff00)",
45:    //   "-webkit-background-clip": "text",
46:    //   "-webkit-text-fill-color": "transparent",

frontend-dashboard/src/index.css
56:::-webkit-scrollbar {
60:::-webkit-scrollbar-track {
64:::-webkit-scrollbar-thumb {
69:::-webkit-scrollbar-thumb:hover {

frontend-dashboard/src/components/Input/SearchInput.tsx
22:    "& ::-webkit-outer-spin-button, & ::-webkit-inner-spin-button": {
23:      "-webkit-appearance": "none",

frontend-dashboard/src/components/Input/Input.tsx
leomayleomay commented 2 years ago

@toastal I am wondering if there's a PR?