Currently there's a boolean in the state for something like isDarkTheme. I think we should be using a Enum like type Theme = Light | Dark so that it can be extended in the future for additional themes, the default can easily be reset, it will just read nicer being explicit (isDark, does this necessarily imply an isLight?).
toastal
commented
2 years ago
Currently there's a boolean in the state for something like
isDarkTheme. I think we should be using a Enum liketype Theme = Light | Darkso that it can be extended in the future for additional themes, the default can easily be reset, it will just read nicer being explicit (isDark, does this necessarily imply anisLight?).