search

ArdanaLabs / DanaSwapUI

Other
3 stars 3 forks source link

Fix build; make dream2nix use nodejs 16, regenerate package-lock files #91

Closed yusdacra closed 2 years ago

yusdacra commented 2 years ago

I had to remove eslint from devDependencies because npm was complaining about it. I'm not sure how this matters, but it seems to build fine.

toastal commented 2 years ago

We should keep eslint and make it a part of nix check. I could see the argument however to use eslint from nodePackages.

yusdacra commented 2 years ago

We should keep eslint and make it a part of nix check. I could see the argument however to use eslint from nodePackages.

Yes, I think we can use eslint from nodePackages. I will work on that to add a checks outputs.

yusdacra commented 2 years ago

@toastal I added a checks output that checks with eslint and also added eslint to devshell. I could only make it check frontend-dashboard and frontend-vault since frontend-landing doesn't seem to have a eslint config.

toastal commented 2 years ago

We should open a new issue where we make an ardana-eslint-config project inside the npm Workspaces where we can share and reference a shared config rather than risking any of these projects looking different.

yusdacra commented 2 years ago

We should open a new issue where we make an ardana-eslint-config project inside the npm Workspaces where we can share and reference a shared config rather than risking any of these projects looking different.

Okay, can this be merged then (after you review) and then we make that issue so we can follow up later?