search

ArianaKhit / text-snippets-obsidian

Snippets plugin for obsidian
177 stars 21 forks source link

Fix Onload Error #40

Closed Voark closed 2 years ago

Voark commented 2 years ago

Closes #39

Did not do any extensive testing, however it just worked for me.

Also modified packages because I wasn't able to install what was there previously.

Voark commented 2 years ago

Forgot to add async to onunload(), fixed now.

PeteMichaud commented 2 years ago

Hey @Voark I forked off your fork to try to fix my own issue and went down a rabbit hole of refactoring. I wanted to submit a PR or issue to you so I could get your feedback, but you don't have those enabled on your forked repo, so I'm pinging you here. Here's the stuff I was hoping for feedback on: https://github.com/PeteMichaud/text-snippets-obsidian/issues/1

It may be possible, with @ArianaKhit's blessing, to get your version moved into the community hub github org so others can continue improving the plugin if Ariana is no longer up for it.

Voark commented 2 years ago

Hi @PeteMichaud, I took a quick look and you addressed a lot of things I was thinking of refactoring as well, especially with the migration to the Obsidian Editor abstraction, but I gave up after not too long because it seemed too complex of a task (seems like you seem to be having trouble too). I'll look a little closer over the next few days and hopefully can leave some feedback but I'm not too familiar with the codebase or the Obsidian Plugin API, as you can see from my bootleg fix for the issue in this PR.

About taking over this plugin, I don't think I have the experience or knowledge to assume that role. However I wouldn't mind being added as a collaborator in this repo or another one to help things move along a bit.