search

Arisstath / roblox-dissector

Roblox UDP Protocol Dissector
MIT License
133 stars 16 forks source link

Ticket generation / 2Captcha support #21

Closed ghost closed 5 years ago

ghost commented 5 years ago

Ticket generation methods 2Captcha support Small Client optimization.

Gskartwii commented 5 years ago

Thanks for the PR! I'm always happy to receive contributions.

When it comes to the changes the PR provides, I'll be happy to merge the changes in peer/Client.go. However, I feel that Roblox login functionality is out of scope for this project, and would be better suited for a third-party library. The goal of Sala is to provide insights into the Roblox UDP protocol and create implementations for developers and others to study and learn. The Client is meant to emulate the Roblox Player client, which only receives an authticket for the browser. The login functionality that was previously present in the GUI package was for testing purposes and was never intended to be permanent. I have been planning on creating a Chrome extension for extracting authtickets, which would be separate from Sala, and I don't have any plans on providing first-party support for 2Captcha for personal/moral reasons. Feel free to create a separate third-party package for providing Roblox auth functionality.

That being said, I'll be more than happy to merge the Client error message change once the Roblox auth code is removed. I look forward to any future contributions!