ArkProjectNFTs / ark-project

ArkProject is a liquidity layer for digital assets, uniting markets, empowering creators, and bridging the gap to mass adoption. Built on top of Starknet, ArkProject is designed to provide a fully decentralized and trustless orderbook on-chain.
https://arkproject.dev
Apache License 2.0
25 stars 8 forks source link

Deployer fix: Update orderbook contract & starknet nft contract #275

Open kwiss opened 5 months ago

kwiss commented 5 months ago

Describe the bug

We need to have the ability to update if the contract already exist the orderbook contract & starknet nft contract

To Reproduce

Deploy both contracts with the deployer

it also cause the CI to always deploy a new orderbook contract instead of updating it

princeibs commented 4 months ago

Hi @kwiss, if work has not commenced on this issue, I would like to proceed with it.

kwiss commented 4 months ago

Hey @princeibs sure, i think it's pretty easy to do, you just have to reproduce the logic in https://github.com/ArkProjectNFTs/ark-project/blob/main/packages/deployer/src/deployStarknetContracts.ts (deploy a new contract or update it if it doesn't exists)

here: https://github.com/ArkProjectNFTs/ark-project/blob/main/packages/deployer/src/deployArkchainContracts.ts & here: https://github.com/ArkProjectNFTs/ark-project/blob/main/packages/deployer/src/deployStarknetFreemintNft.ts

To work with this PR you have to make the whole thing locally you can follow this guide: https://github.com/ArkProjectNFTs/ark-project/blob/main/packages/deployer/README.md#running--deploying-arkproject-locally

princeibs commented 4 months ago

It looks like something I can do @kwiss. You can assign me to the task. Thanks

kwiss commented 4 months ago

good @princeibs do you need some help on it ? or some explanations ? we call do a call

princeibs commented 4 months ago

Hello @kwiss, just want to let you know that work is still in progress. I will create a PR once I am done

ybensacq commented 4 months ago

@princeibs dont hesitate to ask if you have any question.

princeibs commented 4 months ago

@princeibs dont hesitate to ask if you have any question. Surely I won't. Thanks