ArkProjectNFTs / ark-project

ArkProject is a liquidity layer for digital assets, uniting markets, empowering creators, and bridging the gap to mass adoption. Built on top of Starknet, ArkProject is designed to provide a fully decentralized and trustless orderbook on-chain.
https://arkproject.dev
Apache License 2.0
27 stars 26 forks source link

feat(starknet): add fulfill in starknet executor #417

Open ptisserand opened 4 months ago

ptisserand commented 4 months ago

Description

  1. Add a mapping (order_hash -> bool) to ensure that transaction will be reverted if order is fulfilled.

@kwiss I'm wondering if we should add an admin only method to revert fulfilled status of a given order hash to prevent deadlock if layer3 fulfill failed: wdyt ?

What type of PR is this? (check all applicable)

Related Tickets & Documents

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

Closing Issues

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
ark-project-sdk-demo āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Jul 29, 2024 8:34pm
changeset-bot[bot] commented 4 months ago

āš ļø No Changeset found

Latest commit: 848eaacedd8fdc06175071fb37f48508ba1a9b11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linear[bot] commented 4 months ago

DEV-663 Add Fulfill in Starknet executor