ArkProjectNFTs / ark-project

ArkProject is a liquidity layer for digital assets, uniting markets, empowering creators, and bridging the gap to mass adoption. Built on top of Starknet, ArkProject is designed to provide a fully decentralized and trustless orderbook on-chain.
https://arkproject.dev
Apache License 2.0
27 stars 26 forks source link

feat(orderbook): implement new executed event #419

Closed ptisserand closed 3 months ago

ptisserand commented 3 months ago

Description

  1. Update orderbook::OrderExecuted event with the following data:
    #[derive(Drop, starknet::Event)]
    struct OrderExecuted {
        #[key]
        order_hash: felt252,
        #[key]
        order_status: OrderStatus,
        version: u8,
        transaction_hash: felt252,
        from: ContractAddress,
        to: ContractAddress,
    }
  2. Update diri to handle OrderExecuted version 0 and version 1

What type of PR is this? (check all applicable)

Related Tickets & Documents

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

Closing Issues

linear[bot] commented 3 months ago

DEV-598 Implement new executed event

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: fd13d3737433f97a679ad9fe8f6bd4189494d633

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ark-project-sdk-demo βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 16, 2024 3:21pm