Armael / marracheck

Gotta check them all!
10 stars 3 forks source link

Commit report-items on the fly during each cover-element build #4

Closed gasche closed 4 years ago

gasche commented 4 years ago

(On top of #3.)

This PR uses the new ?report_action_result argument we added to OpamSolution.apply.

I tested the code and it seems to behave as expected. By inspecting the git logs, I cannot check that the file only gets appended-to, but I could check that killing and restarting marracheck is able to parse back the synchronized logs and keep appending to it correctly.

Two potential issues I realized while working on this:

  1. We may later need more instrumentation of OpamSolution.apply, for concurrency control: if we want to have the information that one cover-element worker is in the process of performing an action, and be able to delay other workers that are trying the same action, then we need to also have a callback before an action starts, not only after it finishes. We may have to rework the opam-side API, so in particular I think we should not try to upstream ?report_action_result yet, until we figured this out.
gasche commented 4 years ago

(I rebased this on top of master now that #3 is merged.)