[BUG] Input fields get random symbols like "[B[AA1" or "B" and others pasted in on every action

DavidLazarescu commented 3 years ago

Input fields get random symbols like "[B[AA1" or "B" and others pasted in on every action like typing, using the arrow keys and moving the mouse

ArthurSonzogni commented 3 years ago

Hello, what kind of terminal emulator are you using?

ArthurSonzogni commented 3 years ago

In particular, what sequence of byte it sent when you are using the example

./example/util/print_key_press and use your keyboard?

You should get those numbers:

│( 27 91 65 ) -> (special)                                                                               │
│( 27 91 68 ) -> (special)                                                                               │
│( 27 91 66 ) -> (special)                                                                               │
│( 27 91 67 ) -> (special)                                                                               │

You can try it online against the xterm.js terminal emulator and check you receive the same sequences: https://arthursonzogni.com/FTXUI/examples/?file=./util/print_key_press.js

DavidLazarescu commented 3 years ago

It changes how extreme it is, sometimes even more symbols than here get pasted in. https://streamable.com/mg7g85 All actions make this happen, deleting, switching with arrow keys or just writing.

AhmedMostafa16 commented 3 years ago

Hello, what kind of terminal emulator are you using?

Windows CMD. I have tried PowerShell, but the same.

DavidLazarescu commented 3 years ago

Hello, what kind of terminal emulator are you using?

Windows CMD. I have tried PowerShell, but the same.

@ArthurSonzogni we are working on the same project btw, so i m using Windows CMD too. Btw, its not the same symbols your https://arthursonzogni.com/FTXUI/examples/?file=./util/print_key_press.js shows me

DavidLazarescu commented 3 years ago

@ArthurSonzogni, do u have any idea?

ArthurSonzogni commented 3 years ago

I finally was able to test on Windows. There are several problems I tried to mitigate with: https://github.com/ArthurSonzogni/FTXUI/pull/138

However I was not able to reproduce your problems. I just saw you made a video. This help a lot. Thanks!

DavidLazarescu commented 3 years ago

I finally was able to test on Windows. There are several problems I tried to mitigate with:

138

However I was not able to reproduce your problems. I just saw you made a video. This help a lot. Thanks!

What should we do now? If you check my github account, you can find my project called "PW-Manager" clone it and run it, you ll see the errors too

ArthurSonzogni commented 3 years ago

I tried locally on "gallery.exe", using visual studio. It seems to be working. https://user-images.githubusercontent.com/4759106/124385624-d46da680-dcd6-11eb-9ca5-f7c46bdfe96e.mp4

Maybe this is caused by your project? Then I should try directly your project.

AhmedMostafa16 commented 3 years ago

I tried locally on "gallery.exe", using visual studio. It seems to be working. https://user-images.githubusercontent.com/4759106/124385624-d46da680-dcd6-11eb-9ca5-f7c46bdfe96e.mp4

Maybe this is caused by your project? Then I should try directly your project.

I have tried the same project on Linux, but it works well. Edit: I have cleaned the project and tried again. I have fetched the latest changes of FTXUI, but the bug is still.

DavidLazarescu commented 3 years ago

I tried locally on "gallery.exe", using visual studio. It seems to be working. https://user-images.githubusercontent.com/4759106/124385624-d46da680-dcd6-11eb-9ca5-f7c46bdfe96e.mp4

Maybe this is caused by your project? Then I should try directly your project.

would be awesome if you could try to open it directly, we have one global screen which the requested file renders to, maybe this could be a problem.
(As a side question, do you provide any option to mask text, for example passwords?)

DavidLazarescu commented 3 years ago

I tried locally on "gallery.exe", using visual studio. It seems to be working. https://user-images.githubusercontent.com/4759106/124385624-d46da680-dcd6-11eb-9ca5-f7c46bdfe96e.mp4 Maybe this is caused by your project? Then I should try directly your project.

I have tried the same project on Linux, but it works well. Edit: I have cleaned the project and tried again. I have fetched the latest changes of FTXUI, but the bug is still.

@ArthurSonzogni, i ve tried it on windows with the ubuntu cmd and it had the same problems

ArthurSonzogni commented 3 years ago

Sorry =, It was very painful for me to try your project. First install windows, then visual studio, then git, then cmake. Then discover I need vcpkg. Then discover SQLite3 was missing. Then trying to use vcpkg to install SQLite3, which errors because I apparently need to install the "english" language pack. Then install the english language pack for visual studio. Trying again installing SQLite. Then trying again cmake with the error:`

CMake Error at CMakeLists.txt:77 (add_subdirectory):
  The source directory

    C:/Users/arthur/programmation/PW-Manager/lib/clip

  does not contain a CMakeLists.txt file.

I have to abandon trying to build your project. Next time, you probably want to abandon vcpkg and directly use cmake fetchcontent for building from source everything you need.

I will take a look at your source code directly instead of trying to reproduce your problem.

DavidLazarescu commented 3 years ago

Sorry =, It was very painful for me to try your project. First install windows, then visual studio, then git, then cmake. Then discover I need vcpkg. Then discover SQLite3 was missing. Then trying to use vcpkg to install SQLite3, which errors because I apparently need to install the "english" language pack. Then install the english language pack for visual studio. Trying again installing SQLite. Then trying again cmake with the error:`
CMake Error at CMakeLists.txt:77 (add_subdirectory):
  The source directory

    C:/Users/arthur/programmation/PW-Manager/lib/clip

  does not contain a CMakeLists.txt file.
I have to abandon trying to build your project. Next time, you probably want to abandon vcpkg and directly use cmake fetchcontent for building from source everything you need.

I will take a look at your source code directly instead of trying to reproduce your problem.

If i can help you in any way, just tell me. Thanks for your quick replys btw

ArthurSonzogni commented 3 years ago

Sorry, I looked too quickly. You don't use vcpkg and the missing file in lib/clip is just because I need to ask git to clone recursively.

DavidLazarescu commented 3 years ago

Sorry, I looked too quickly. You don't use vcpkg and the missing file in lib/clip is just because I need to ask git to clone recursively.

so does it work now?

AhmedMostafa16 commented 3 years ago

Sorry, I looked too quickly. You don't use vcpkg and the missing file in lib/clip is just because I need to ask git to clone recursively.

@ArthurSonzogni you can use "git update submodule --init --recursive"

ArthurSonzogni commented 3 years ago

Yes, I just tried on Linux. Working very well. Nice app! I now need to got on Windows.

DavidLazarescu commented 3 years ago

Yes, I just tried on Linux. Working very well. Nice app! I now need to got on Windows.

Thanks for your positive feedback, would be awesome if you could help us with also getting it working on windows

AhmedMostafa16 commented 3 years ago

Yes, I just tried on Linux. Working very well. Nice app! I now need to got on Windows.

@ArthurSonzogni To build it on windows: vcpkg install sqlite3 git update submodule --init --recursive then build from your Visual Studio 19

ArthurSonzogni commented 3 years ago

Gravité Code    Description Projet  Fichier Ligne   État de la suppression
Erreur      CMake Error at C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineSystem.cmake:129 (message):
  Could not find toolchain file:
  D:\src\vcpkg\scripts\buildsystems\vcpkg.cmake     C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineSystem.cmake    129

ArthurSonzogni commented 3 years ago

I guess that's because of this file: https://github.com/Creapermann/PW-Manager/blob/ba0f0cf0446d4ae44c6f8eb01818cae0433f56b7/CMakeSettings.json

AhmedMostafa16 commented 3 years ago

This is a binary file with the latest changes of FTXUI.

pw-manager.zip

ArthurSonzogni commented 3 years ago

Okay, I found it.

What you see are the windows terminal replying to the request about reporting the cursor position relatively to the screen. This isn't really useful in fullscreen mode, because it will always report (1,1). This is useful with ScreenInteractive::TerminalOutput() for instance.

So the windows terminal should output ^[1;1R However due to a bug: https://github.com/microsoft/terminal/pull/7583 and race conditions, it ends up outputting corrupted:

^[^[1;1R[1;1R
^^      ^^^^^ First CPR
  ^^^^^^ Second CPR

I will add one more time "mitigation" so that this bug won't affect FTXUI most of the time.

AhmedMostafa16 commented 3 years ago

Okay, thank you for your time and efforts @ArthurSonzogni

DavidLazarescu commented 3 years ago

Okay, I found it.

What you see are the windows terminal replying to the request about reporting the cursor position relatively to the screen. This isn't really useful in fullscreen mode, because it will always report (1,1). This is useful with ScreenInteractive::TerminalOutput() for instance.

So the windows terminal should output ^[1;1R However due to a bug: microsoft/terminal#7583 and race conditions, it ends up outputting corrupted:
^[^[1;1R[1;1R
^^      ^^^^^ First CPR
  ^^^^^^ Second CPR
I will add one more time "mitigation" so that this bug won't affect FTXUI most of the time.

this is awesome, thanks a lot. Would it reduce it a lot, like 90% or smth or would it just help a little? When do you think u'll have the time to implement it?

DavidLazarescu commented 3 years ago

@ArthurSonzogni, thanks for your help! Btw, one more off topic question. Do you provide any way to mask input? for example passwords?

ArthurSonzogni commented 3 years ago

This doesn't exist, but I believe I should add an option for that: https://github.com/ArthurSonzogni/FTXUI/issues/139

ArthurSonzogni / FTXUI

[BUG] Input fields get random symbols like "[B[AA1" or "B" and others pasted in on every action #136

138