Segmantation fault launching every example after last commit

ArthurSonzogni / FTXUI

:computer: C++ Functional Terminal User Interface. :heart:

MIT License

6.64k stars 399 forks source link

Segmantation fault launching every example after last commit #19

Closed GiuseppeCesarano closed 4 years ago

GiuseppeCesarano commented 4 years ago

I was doing the small changes required by the last commit to my code base. Running my application i was getting a "segmentation fault", so i decided to test with the examples, every example crashed for the same reason.

ArthurSonzogni commented 4 years ago

Thanks for reporting this!

ArthurSonzogni commented 4 years ago

This was introduced by: https://github.com/ArthurSonzogni/FTXUI/commit/e34f051f7aa31538f22b03130ec0656022a39419

And this failed the tests: https://travis-ci.com/github/ArthurSonzogni/FTXUI/builds/167512229

ArthurSonzogni commented 4 years ago

I just added protection on the master branch to prevent merge that haven't pass the tests. This will prevent future regressions.