search

ArthurSonzogni / FTXUI

:computer: C++ Functional Terminal User Interface. :heart:
MIT License
7.02k stars 427 forks source link

Radiobox doesn't accept enter event #487

Open jdfa opened 2 years ago

jdfa commented 2 years ago

RadioboxBase::OnEvent returns false for Event::Return: https://github.com/ArthurSonzogni/FTXUI/blob/24e04faf36bf0954272200b0bf51c4305e8b8dfc/src/ftxui/component/radiobox.cpp#L107

ArthurSonzogni commented 2 years ago

Yes, I believe you are right. Do you want to submit a PR fixing this?

jdfa commented 2 years ago

Yes, I can do that. Do we need to pass event further if current radiobutton was selected before current event?

ArthurSonzogni commented 2 years ago

Yes, I believe we should return true unconditionnally.