search

Aslam97 / shadcn-minimal-tiptap

Minimal Tiptap Editor
https://shadcn-minimal-tiptap.vercel.app
MIT License
816 stars 38 forks source link

uploadFn executes twice #56

Closed markbulingit closed 2 weeks ago

markbulingit commented 2 weeks ago

I use Supabase to store the images, problem is it gets executed twice.

On this image, I just upload one image but got 2 identical images. image

Aslam97 commented 2 weeks ago

@markbulingit thank you for reporting this. take a look at this PR https://github.com/Aslam97/shadcn-minimal-tiptap/pull/57

markbulingit commented 2 weeks ago

@Aslam97 awesome man! thank you for quick response the problem has been fixed, just one more bug I noticed here's to reproduce:

Situation #1:

  1. Do not type anything on the editor.
  2. Just straight up upload an image file.
  3. Check the onChange value of editor.
  4. NO VALUE, even if there's an image successfully uploaded.

image

Situation #2:

  1. Type something on the editor.
  2. Upload an image file.
  3. Check the onChange value of editor.
  4. VALUE IS PRESENT -everything is good.

image

Aslam97 commented 2 weeks ago

@markbulingit Could you create a new issue for it? It's not related to the current issue. I'll close this issue now since the original problem has been fixed.