use a different separator than page break (^L)

[chadwhitacre]

Pretty much since the beginning people have been saying that ASCII page breaks are too weird. We relaxed the constraint to caret-ell as a result. @dcrosta rewrote the framework more or less to get a different separator. Whatever it is in Ruby that does something similar uses something different. The latest thready discussion is leaning the same way:

http://www.reddit.com/r/Python/comments/1b3t09/why_gittip_use_aspen_instead_of_djangorails/

So let's maybe do that. How about the separator is \n----+(.*)\n, where the group is used as the specline (specifying which syntax the following page is).

[chadwhitacre]

Thanks for chiming in, @warsaw. Love the history! :D

@Lucretiel Re: question in IRC ... padding is so we get accurate line numbers in tracebacks. We haven't had tests for that but we should.

[chadwhitacre]

@pjz You up to review and merge @Lucretiel's work?

[chadwhitacre]

@Lucretiel I gave your branch a once-over and it looks good on the surface. Is this ready for a full review? What are you seeing as next steps?

[Lucretiel]

Yeah I'd say it's good to go at this point. The only thing still missing finishing updating some of the negotiated_template tests

[pjz]

Looks good, so I merged it; re-open this if there are issues with it.

[chadwhitacre]

Damn. Good honkin' work, everyone! Big thanks to @Lucretiel for implementing this and to @pjz for reviewing/merging.

The tests are passing for me and I'm seeing [-----------------] in the simplates in docs/. Did some poking at speclines and that seems to be working as well.

We need to update the docs, themselves, though. We're still talking about ^L. There's a make doc target to run the docs locally from a clone.

[chadwhitacre]

Escaping doesn't work.

[Lucretiel]

Can you give an example? The tests were (I believe) passing. On Apr 15, 2013 2:42 PM, "Chad Whitacre" notifications@github.com wrote:

Escaping doesn't work.

— Reply to this email directly or view it on GitHubhttps://github.com/gittip/aspen-python/issues/167#issuecomment-16403633 .

[chadwhitacre]

@Lucretiel Am I reading that wrong?

[chadwhitacre]

I noticed this while updating the docs.

[chadwhitacre]

@Lucretiel Is this something you think you'll be able to take a look at? I leave for NYC early tomorrow. Would love to have this released and implemented on Gittip before tomorrow night's talk at NYCPython.

[Lucretiel]

Keep in mind that the check_page_content helper only tests paginating, not escaping. I don't believe I have any tests written that test splitting and escaping together; recall that they are separate operations, and only sewn together by the simple method split_and_escape. I'm working on a test that ensures that the escaped lines are left untouched.

[Lucretiel]

Bug found. My code, and all my tests, use / as the escape character, not . Fixing.

[pjz]

So the issue here is that @Lucretiel wrote escaping with forward slashes and @whit537 tried to escape using backslashes. The docs in this issue say to implement using backslashes. My bad for not catching that in code review. @Lucretiel think you can fix it and shoot me a pull request?

[chadwhitacre]

Phew. :)

[chadwhitacre]

@Lucretiel @pjz I'll stop with the changes to master for now while we fix this.

[chadwhitacre]

I'm going to start looking at #148 but I'll lay off master.

[chadwhitacre]

@Lucretiel Also, may I add you as a collaborator on the Gittip org with perms on this repo (aspen-python)? You do good work. :)

[Lucretiel]

By all means

Sent from my Galaxy Nexus On Apr 15, 2013 3:25 PM, "Chad Whitacre" notifications@github.com wrote:

@Lucretiel https://github.com/Lucretiel Also, may I add you as a collaborator on the Gittip org with perms on this repo (aspen-python)? You do good work. :)

— Reply to this email directly or view it on GitHubhttps://github.com/gittip/aspen-python/issues/167#issuecomment-16406109 .

[chadwhitacre]

@Lucretiel Done. Welcome aboard. :)

P.S. You should consider joining Gittip when you get a chance:

https://www.gittip.com/on/github/Lucretiel/

[pjz]

bugs fixed as of ee371e4eda. Still need docco update.

[pjz]

Actually looks like @whit537 fixed the docs yesterday. Closing this unless/until other bugs found.

[Lucretiel]

Changed to be a raw string. Regarding @whit537's regression commit: I originally had that stuff in a different module, but I didn't want to disrupt the model of all the modules in resources being resource types.

[Lucretiel]

Reverted

[pjz]

Ugh, I owe you an apology. Turns out that while r'' keeps the python interpreter from turning \n into a newline, the regex interpreter will then do it. So it was working after all. either way works; escape hell is still escape hell :)

[chadwhitacre]

@pjz sez we're not allowed to change this again for at least 6 months. :)