I've reviewed the changes from 2019-04-29 onwards.
Here are the comments. There are quite a few cases where I don't think that the stylistic differences actually make a difference but I've flagged them anyway.
[x] AnalyticsServer#76 - Hard link to /data/image-service/config/google-analytics.json no
[x] ScheuldeMissingImagesBackgroundTask#23 - Needs to create directory if absent
[x] application.yml#140 - Needs default imageservice.imagestore.inbox (generally needs defaults for things used in config or a graceful failure)
[x] imageimport.gsp#37 script tag outside body is not rendered
[x] DarwinCoreField This seems to be a redundant implementation of the GBIF Term vocabularies?
[x] ImageUtils#76 Pattern could be made static constant
[x] ImportFieldValueExtractor Is it worth having a separate, reusable regexcache class?
[x] ImportFileBackgroundTask and friends. I'm a little unclear as to why in some cases the variables are private and some cases they're not
[ ] MapResourceFileGenerator#29 Hard coded service URL(?)
[x] ResultsPage consider delegation to _pageList, file name and class name don't match
[x] SearchCriteria/SearchCriteriaDefinition serializable but no serialisation UID
[x] images.gsp Does Githubissues.
Githubissues is a development platform for aggregating issues.
Hi Dave,
I've reviewed the changes from 2019-04-29 onwards.
Here are the comments. There are quite a few cases where I don't think that the stylistic differences actually make a difference but I've flagged them anyway.