search

AtlasOfLivingAustralia / image-service

Image repository and tiling services
https://images.ala.org.au
0 stars 17 forks source link

Hard coded imageServiceBaseUrl in JS file #62

Closed andrevtg closed 4 years ago

andrevtg commented 5 years ago

We found a hard coded URL reference in "plugins/images-client-plugin-0.8/js/ala-image-viewer.js":

    var imageServiceBaseUrl = "https://images.ala.org.au";

This broke some js interactions in our runtime (can't recall where right now). We are patching this post-install in our setup with sed, maybe ansible playbooks should do the same.

djtfmartin commented 5 years ago

Hmmm - this should be overriden in the configuration files. There shouldnt be a need to use sed. Im guessing theres a property that hasnt been set in an external configuration file (properties or YAML).

Which version are you using ?

andrevtg commented 5 years ago

We saw this behaviour in 0.9 and the code looks the same now on 1.0.1. I am asking my team on how to reproduce the problem

djtfmartin commented 4 years ago

@andrevtg Im unable to reproduce these issues so im going to close (tested in multiple environments now). Please reopen if you have any further information. Thanks for opening it.