AudreyBeard / compressure

4 stars 1 forks source link

SPIKE: is the output failing because of different framerates or chroma subsampling or both? #19

Closed AudreyBeard closed 1 year ago

AudreyBeard commented 1 year ago

Since compressure relies on the concat protocol, there are issues that crop up when trying to combine different sources with different framerates or chroma subsampling. I'm not sure which is the case yet, so need to do a spike to figure it out

AudreyBeard commented 1 year ago

concatenation with different codecs still require identical framerate. But our current implementation requires them to have the same codecs and "codec properties," so maybe it's both

AudreyBeard commented 1 year ago

The "concatenation with different codecs" comment above is concerned with the concat filter, which seems to still require a lot of matching properties

AudreyBeard commented 1 year ago

It looks like single framerate is explictly required for AVI files, which is the output format. Chroma subsampling is probably required to match, since I've never seen variable-subsampling in videos

AudreyBeard commented 1 year ago

turns out it was chroma subsampling and audio channels! We'll see if the framerate is problematic later