search

AuraQ / AutoCompleteForMendix

An autocomplete widget for mendix
Apache License 2.0
8 stars 31 forks source link

isCurrency is removed in mendix 8 #51

Closed JamesRamm closed 4 years ago

JamesRamm commented 5 years ago

the isCurrency method of MxMetaObject has been removed in mendix 8, meaning this widget crashes due to line 867 of AutoCompleteForMendix.js

According to release notes, functions deprecated in Mx 7 were removed in v3.0.

I suggest to remove all uses of isCurrency

lindski commented 4 years ago

This has now been fixed in version 5 of the widget

jvink commented 4 years ago

Using version 5, and this issue is still not fixed. I also see the isCurrency method still being used in the source code: https://github.com/AuraQ/AutoCompleteForMendix/blob/v3/src/AutoCompleteForMendix/widget/AutoCompleteForMendix.js

image

lindski commented 4 years ago

Hi, you have linked to the source code for version 3 of the widget... have you definitely updated your project to version 5?

Version 5 of the widget now contains the following

( obj.isCurrency && obj.isCurrency(attr) )

which first tests for the availability of isCurrency before attempting to execute it. This is required for backwards compatibility with version 7

jvink commented 4 years ago

image Yes, we are using version 5 of the widget. image Looks like it is still using the old version? This is what the code looks likes when I check the /widgets directory.

lindski commented 4 years ago

I've just downloaded version 5 from the app store into v8.0.0 and it is showing the correct version (with the updated source).

What version of Mendix are you using? Maybe you could try deleting the widget from your project and attempting to download again?

jvink commented 4 years ago

Sorry, this seemed to be a Mendix problem. Mendix did not recognise the updated widget. After a while it finally updated the widgets correctly. Thanks for the quick response!