search

Aurora-Modders / AuroraLoader

A tool for discovering and safely managing Aurora mods
MIT License
10 stars 5 forks source link

Fix stale theme references in database #56

Open 01010100b opened 4 years ago

01010100b commented 4 years ago

Right now theme mods add to the base game, but they can not replace the base game theme. The reason for this is that the database saves the files as strings and for example an NPR may have chosen a particular flag, if that flag is removed from the Flags folder then the game will give an error.

The proposed fix is that before launch the database is read and any stale file references are replaced with a random existing file reference.

thashepherd commented 4 years ago

We can paper this over, I'm just not sure that AuroraLoader should adopt a policy that encourages deleting the vanilla images (I'm suspicious that there are .exe references as well). When people start building theme mods for non-player races we can just make sure that they don't use vanilla images.

01010100b commented 4 years ago

If you can't delete vanilla images then what would be the point of making the base game images their own theme mod? See #57

thashepherd commented 4 years ago

Extracting those images to an always-installed 'base' theme mod would still bring some improvements, I THINK. And there's a good chance we'll figure out how to truly support deleting images in the future, I just haven't gotten that far yet