search

Autodesk / arnold-usd

Arnold components for USD
https://www.arnoldrenderer.com/
Other
236 stars 56 forks source link

Typo: Fix missing semicolon #1883

Closed BigRoy closed 3 months ago

BigRoy commented 3 months ago

Changes proposed in this pull request

Issues fixed in this pull request

Admittedly my C++ knowledge is limited and I'm not even sure whether this would be a bug originally or it just ends up being 'cosmetics'. I suspect at the very least that not having a semicolon there might have unexpected behavior - so this at least matches things cosmetically.

cpichard commented 3 months ago

Hi @BigRoy , thanks for the contribution, would you be able to send us the CLA signed ( https://github.com/Autodesk/arnold-usd/blob/master/CONTRIBUTING.md ) ? We need that in order to merge the PRs. Thanks, Cyril

BigRoy commented 3 months ago

Hi @BigRoy , thanks for the contribution, would you be able to send us the CLA signed ( https://github.com/Autodesk/arnold-usd/blob/master/CONTRIBUTING.md ) ? We need that in order to merge the PRs. Thanks, Cyril

Hi Cyril, no problem. There are existing commits by me in the repo so I wonder if I had already done this in the past actually. :) Five years ago!

cpichard commented 3 months ago

Hi, we didn't find you in the list I am afraid, may be those commits date before legal requirements ? Thanks again, C