Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

Earn blocks: "Sales disabled" notice after reconnecting to Stripe #16989

Closed mmtr closed 1 year ago

mmtr commented 4 years ago

When a user disconnects their Stripe account in wordpress.com/earn/payments, all plans are invalidated by setting a 'account_disconnected' => true flag in all of them (see A8C\Billingdaddy\Api\Connected_Accounts::disconnect_connected_account in the WP.com codebase).

That ensures that any existing Earn block (Payments, Premium Content, Donations) don't go through the checkout process if a user tries to submit a payment. Instead we display a "Sales disabled" notice:

Screen Shot 2020-08-26 at 14 18 26

However, if that user decides to reconnect their Stripe account, the account_disconnected flag is not removed from the plans, so all Earn blocks previously published continue displaying the "Sales disabled" notice.

This can be worked around for the Payments and Premium Content blocks, since a user can delete the old plan and create a new one that won't have the account_disconnected flag. But for the Donations block this is rather problematic, since a user cannot manage donation-type plans, so Donations blocks published after the reconnection won't work either.

selectedselections commented 3 years ago

15433397-hc

Follow up #3982067-zen

So far, no workarounds have helped to resolve

noteeth commented 3 years ago

28480129-hc

Follow up #3987768

We walked through workaround which didn't help, though this issue is with the donations block and it sounds like the workaround is not setup to work for this block.

susanjanec commented 3 years ago

Another report of this here - 3985307-zen

julsyd commented 3 years ago

Another report here: 3980302-zen

jenlynnemc commented 3 years ago

Another report here: 3993368-zen Suggested the workaround, although it does not appear to work for the donation block, from reading above.

annacmc commented 3 years ago

another report here: 28387386-hc They are using donations block, but they are going to try PayPal donation button in the meantime.

nagpai commented 3 years ago

Another report here

3999248-zen

dcoleonline commented 3 years ago

4028987-zen (payment block, but given the workaround)

dhackneya8c commented 3 years ago

Another site with this issue here: #29896866-hc

Would appreciate it if the sandbox workaround could be run for them. Thanks!

tanjoymor commented 3 years ago

Another site with this issue here: #29974446-hc

Would appreciate it if the sandbox workaround could be run for them. Thanks!

cc @michaeldcain

sbathompson-he commented 3 years ago

I just found this issue here as well: 30018128-HC

Opened a ticket for them: 4050745-zen

Nic-Sevic commented 3 years ago

Another instance here: 4062309-zen

They were originally having issues with the payments block as well but reconfigured their Stripe account and got them working. Now, they are only having issues with donations blocks Per this thread with a similar case it sounds like switching Stripe accounts is still the issue: p1615859105014200-slack-CS0SC36SX

@ michaeldcain would you be able to run the sandbox fix you mention for this site please?

Robertght commented 3 years ago

@michaeldcain Can we get a hand with this one as well, please?

michaeldcain commented 3 years ago

In D63079-code, we're now deleting donation products when Stripe gets disconnected. This should effectively prevent this issue from happening in the future, but doesn't fix it for users already in this state. I'll pull together a script to run on the users in this thread.

jp-imagines commented 3 years ago

Another report for the user in 4099663-zen. Could you take a look at this one as well, @michaeldcain?

donalirl commented 3 years ago

Another report in #4107714-zen. Is this something we can fix?

rosepajaroja commented 3 years ago

Another report in zd-4104153

cuemarie commented 3 years ago

Returning user with this issue persisting on their site, originally reported on may 31 above: 4136689-zen

poojashetty18 commented 3 years ago

Another report on 30212485-hc

tanjoymor commented 3 years ago

Another report on 31004750-hc

wpshellbelle commented 3 years ago

Another report on 30156645-hc Reconnecting Stripe and then deleting old payment plans and adding new payment plans resolved issue for this user.

jartes commented 3 years ago

Another one on 29443169-hc

Suggested removing the donation block and re-connect their Stripe account. Waiting for confirmation on: 4219260-zen

marutim commented 3 years ago

Another report here: 31071027-hc

DavidSaladu commented 3 years ago

Another report in 4238162-zd-woothemes

mikeicode commented 3 years ago

4248407-zd-woothemes Payments block, asking them to reconnect Stripe

ash1eygrace commented 3 years ago

Reported in 4249614-zen-woothemes

AtrumGeost commented 3 years ago

Got another report here 4250514-zd-woothemes asked the user to reconnect Stripe and re-add the Donations block

arinoch commented 3 years ago

4249614-zd-woothemes was reopened, the workaround suggested didn't resolve the user's issue.

ClassicRKR27 commented 3 years ago

Another report 31368988-hc

donalirl commented 3 years ago

This came up in #25641117-hc for the Premium Content buttons. We have tried deleting the payment plan and creating a new one, but the Sales Disabled notice persists. No error notices in their Stripe account. I'd like to avoid having to create a new Stripe account - @michaeldcain is there something you can do to get this working for this and other recently-reported cases?

sajmes commented 3 years ago

Another report: 4275252-zd-woothemes

benchilcote commented 3 years ago

Another report: #4313971-zen

Sandkorner commented 2 years ago

31806370-HC Might be the same/similar issue as well. User is trying to delete all and try again connecting Stripe to the Payments block in the widget area.

kerrynicl commented 2 years ago

31041805-HC Another report as well. User tried workaround and that did not resolve issue

a8ck3n commented 2 years ago

Hello @michaeldcain ! I think we might need your noted script fix for #4347649-zen as well.

The user tried the recommended workaround but is still getting the "Plan not found" error.

poojashetty18 commented 2 years ago

Another report on 6559355-hc

gaurav1984 commented 2 years ago

Hi @michaeldcain do we have updates for the users reported on this thread?

mikeicode commented 2 years ago

31990644-hc

Need a followup when this is resolved:

4377455-zd-woothemes

supernovia commented 2 years ago

Hi, we have another case here. Is there still a script that can be run for simple sites? https://wordpress.com/forums/topic/sales-disabled-2/

isocialtish commented 2 years ago

This came up in a Quick Start, I'm having them delete plan, delete Stripe, and then reconnect Stripe and add plan again.

Follow up ticket: #4395421-zen

purplepioneer commented 2 years ago

Hi, do we have an update to share with these customers yet?

4347649-zd-woothemes

bizanimesh commented 2 years ago

This issue is in Payments Blocks in the Project now. So we may start working soon on this.

druesome commented 2 years ago

Hi @michaeldcain ! Are you able to delete the Donations block on treadlie.com.au? Site ID is 183549065.

4347649-zd-woothemes

DavidRothstein commented 2 years ago

Task: Finish script at 406-gh-Automattic/payments-shilling and run it for the affected users.

michaeldcain commented 2 years ago

@purplepioneer: I don't have access to that ticket. Can you provide a url to the page with the broken Donation block?

michaeldcain commented 2 years ago

@isocialtish: Can you provide a url to the page with the broken Donation block?

michaeldcain commented 2 years ago

@supernovia: this user seems to be using simple payments buttons now (not the donations block that this bug applies to). It seems like the original fix of deleting and recreating the plans has worked for the user.

michaeldcain commented 2 years ago

@mikeicode: this user seems to be using simple payments buttons now (not the donations block that this bug applies to). The original fix in this issue of deleting the plan (via Calypso), recreating it, and updating the button should work.

michaeldcain commented 2 years ago

@poojashetty18: this user never responded and doesn't seem to be using a Donation block. If they have an issue with a non-Donation plan, the original fix in this issue of deleting the plan (via Calypso), recreating it, and updating the button should work.

michaeldcain commented 2 years ago

@a8ck3n: I don't have access to that ticket. Can you provide a url to the page with the broken Donation block?