Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Earn blocks: "Sales disabled" notice after reconnecting to Stripe #16989

Closed mmtr closed 2 years ago

mmtr commented 4 years ago

When a user disconnects their Stripe account in wordpress.com/earn/payments, all plans are invalidated by setting a 'account_disconnected' => true flag in all of them (see A8C\Billingdaddy\Api\Connected_Accounts::disconnect_connected_account in the WP.com codebase).

That ensures that any existing Earn block (Payments, Premium Content, Donations) don't go through the checkout process if a user tries to submit a payment. Instead we display a "Sales disabled" notice:

Screen Shot 2020-08-26 at 14 18 26

However, if that user decides to reconnect their Stripe account, the account_disconnected flag is not removed from the plans, so all Earn blocks previously published continue displaying the "Sales disabled" notice.

This can be worked around for the Payments and Premium Content blocks, since a user can delete the old plan and create a new one that won't have the account_disconnected flag. But for the Donations block this is rather problematic, since a user cannot manage donation-type plans, so Donations blocks published after the reconnection won't work either.

michaeldcain commented 3 years ago

@kerrynicl: this user seems to be the same as this one.

michaeldcain commented 3 years ago

@Sandkorner: I'm not seeing a Payment Block on this user's site. Can you provide a url to the page with the broken Donation block?

michaeldcain commented 3 years ago

@benchilcote: this user doesn't seem to have a connected Stripe account or a Donations block. If they reconnect their Stripe account and have an issue with a non-Donation plan, the original fix in this issue of deleting the plan (via Calypso), recreating it, and updating the button should work.

isocialtish commented 3 years ago

@isocialtish: Can you provide a url to the page with the broken Donation block?

Home page of https://leddysetgo.tv/, right under the blue and yellow logo that says "leddysetgo productions" is a blank whitespace area. This is where the donation block is, so if you click in this area you'll see the error.

michaeldcain commented 3 years ago

@isocialtish: I've deleted the donations plans for that user. Can you have the user delete the donations block, save and reload the editor, and add a new donations block?

michaeldcain commented 3 years ago

@donalirl: I don't see where this user has any Payments Blocks active. Can you provide a url to the page with the broken Donation block?

michaeldcain commented 3 years ago

@ClassicRKR27: this user seems to be fixed.

donalirl commented 3 years ago

@donalirl: I don't see where this user has any Payments Blocks active. Can you provide a url to the page with the broken Donation block?

Yes, it's here (Premium Content block): https://live-life-healthy-and-fit-health.com/2021/08/26/common-genetically-modified-foods/

sbathompson-he commented 3 years ago

Howdy! This user reported this and was not able to fix it by disconnecting and reconnecting. 32585701-hc https://thefreedomgrind.blog/products-and-services/

marianearchimbaud commented 3 years ago

Same case here: 32502119-hc It seems like the user used this same Stripe account for another site. https://wellsbaum.blog/stepping-into-the-future/

dragstor commented 3 years ago

I had a chatter today with the same issue: 32599701-HC

✅ Got it resolved by following the steps from this comment: https://github.com/Automattic/jetpack/issues/16989#issuecomment-740564174

jordesign commented 2 years ago

@michaeldcain When you're able - could you please also run the patch for the most recently reported cases:

reginabally commented 2 years ago

I'm following up on this comment.

@michaeldcain Can you please run the script for the site https://730romanticrelationships.com?

Product page: https://730romanticrelationships.com/products/

Noting the interaction for reference: 4449012-hc

wpshellbelle commented 2 years ago

Another report at 24105836-hc Donation Block is not working on site. Reconnecting Stripe didn't help. No existing payment plans.

@michaeldcain Can you please run the script mentioned above for the site https://prjktpayday.com/

seanbelly commented 2 years ago

Another report here: 4465636-zd-woothemes Donation block reports sales disabled. Deleted plan and created a new one, awaiting response.

metabreakr commented 2 years ago

4466307-zen

kosiew commented 2 years ago

Hi @michaeldcain , Can you run the script for site id 182812520 ? ref: #4463364-zen

gabriel-fuentes commented 2 years ago

4532641-zen

syds87 commented 2 years ago

Hi @michaeldcain ,

Could you run the same script for site id 179630244 as well? Reported in #4533699-zen

spsiddarthan commented 2 years ago

Hi @michaeldcain,

The website (blog id: 183549065) mentioned in 4458035-zen appears to have the same issue and needs to be fixed/looked at again.

Issue summary: The Donations block was throwing off an error saying that the Plan is not found.

What has the user tried so far:

The above steps didn't help them resolve the issue.

KirkwallDay commented 2 years ago

Hi @michaeldcain I have a user in this ticket: 4466307-zen with a donations block showing the "Sales disabled" message.

They have tried removing and re-adding the block.

Can you run the script for rbkande.wordpress.com

URL for the page is: rbkande.wordpress.com/2021/07/12/example-post-3/

ccwalburn commented 2 years ago

4466307-zen I let the user know that the issue has been fixed and they can remove the donations block and re-add it following @michaeldcain 's steps.

poeticabdul commented 2 years ago

For 4466307-zen user is back, running the script didn't work for them @michaeldcain

For now, I have suggested they recreate the donation block in a new test post and let us know how that goes

bizanimesh commented 2 years ago

Hi @michaeldcain,

The website (blog id: 183549065) mentioned in 4458035-zen appears to have the same issue and needs to be fixed/looked at again.

Issue summary: The Donations block was throwing off an error saying that the Plan is not found.

What has the user tried so far:

  • Remove the donation block from your pages/posts.
  • Save those pages/posts without the block.
  • Reload the editor again and then add a new donation block.

The above steps didn't help them resolve the issue.

Hey @michaeldcain - is there any other thing that we can try?

annbingle commented 2 years ago

Same issue reported here - 26896965-hc using the Payments Block. I had them delete their current Payments Plan and create a new one. Also, remove and create a new Payments button on their on About page but still the same error.

AnthonyFaxlandez commented 2 years ago

@michaeldcain Hey! Wanted to check and see if you had a chance to take another look at this one yet? 🙂

bobmatyas commented 2 years ago

@michaeldcain Can you take a look and advise if there is anything else we can do? https://github.com/Automattic/jetpack/issues/16989#issuecomment-982179383

goblinartificer commented 2 years ago

another case in 33337017-hc. No donation/payment plans visible, before or after removing/readding blocks or disconnecting/reconnecting Stripe. Problem still persists.

ccwalburn commented 2 years ago

Another report here: 4642555-zen

@michaeldcain - It looks like the fix we tried for a similar situation here 4466307-zen didn't work; is it worth trying for this user or is there another workaround?

(I've asked them to try removing the block and re-adding it in the meantime, just in case)

rinazrina commented 2 years ago

Related to the above ^ 4642555-zen

Removing the button and adding it again did not work for this user.

Codexpart commented 2 years ago

Another report here: 4642725-zen

nagpai commented 2 years ago

For case 4642555-zen - The user also has a WC Payment account ( linked to Stripe Express - check Blog RC or search Stripe Dashboard with the user's email ). My hypothesis (could be wrong), is that if their browser had the session of the Stripe Express on while creating the payment block, this may get latched on to the WP.com Donate block and cause errors ( since it is not a regular Stripe account )

User has now moved on to use GiveWP.

kylemcph commented 2 years ago

Another report 31887032-hc / 4659106-zen. Removing the button and adding it again did not work for this user.

arinoch commented 2 years ago

+1: 4656029-zd-woothemes

Deleting and re-adding the block didn't fix.

gabriel-fuentes commented 2 years ago

4689801-zd

devNigel commented 2 years ago

Another case: 33770811-hc

allanftd commented 2 years ago

Another case, user followed up today 33772060-hc 4706551-zd

ClassicRKR27 commented 2 years ago

Have another case here: 3687943-hc

dragstor commented 2 years ago

Another one: 33853145-hc

Recreating the plans didn't help.

donalirl commented 2 years ago

Seen in #33586431-hc. Would it be possible to run a fix to get their payments working again, @michaeldcain ?

We tried deleting old payment plan and creating a new one. No change. They also checked their Stripe account but saw no errors present.

jordesign commented 2 years ago

Another instance in #4779784-zen. User with donations block - so couldn't create a new payment plan. Re-adding new block and dis/reconnection Stripe connection had no impact.

I'm going to go back through this thread to check the current status - and see what our next steps might be.

thekingsprojects commented 2 years ago

Another case here: 4810674-zen

I've asked them to try recreating the block and dis/reconnecting Stripe; hopefully that will work!

rw-ye commented 2 years ago

Iv'e closed 4779784-zd-woothemes

Please re-open a new ticket with the user when a fix has been deployed.

happychait commented 2 years ago

Another one with the Payments block, in 30713789-hc.

I followed up in 4884217-zen and suggested trying the workaround of removing the existing Payments plans and Stripe connection and re-adding everything.

desnum commented 2 years ago
Screen Shot 2022-04-15 at 11 05 50 AM

Another case for the Donations block on 35135522-hc. I had them disconnect and reconnect Stripe. The message then changed to this on my end:

Screen Shot 2022-04-15 at 11 18 42 AM

Then the user removed and re-added the Donations block, which circled us back to the first "Sales Disabled" error

ClassicRKR27 commented 2 years ago

Another report here: 5185542-zd-woothemes

User has tried reconnecting, re-adding - nothing worked.

marutim commented 2 years ago

Another report here: 15332414-hc

The user created a new payment button, added a new plan, and then disconnected and reconnected Stripe but that did not work.

aleone89 commented 2 years ago

Another report here: zen-5336271

Have asked the user to disconnect Stripe and recreate the donation form.

pottedmeat commented 2 years ago

Patch created in D83897-code

Greatdane commented 2 years ago

Another here; 5366412-zd-woothemes

Asked the user to reconnect Stripe and recreate the donation form.