Make code php 8.3 compliant - Githubissues

Automattic / newspack-custom-content-migrator

Custom migration tasks for launching and migrating Newspack sites on Atomic

5 stars 5 forks source link

Make code php 8.3 compliant #543

Closed naxoc closed 2 weeks ago

naxoc commented 3 weeks ago

Description

We had a few lines that would fatal in PHP 8.3. This fixes that. It also changes the version phpcs checks against.

How to test

Run:
- composer run-script phpcs -- -p --standard=PHPCompatibility --runtime-set testVersion 8.1 src
- composer run-script phpcs -- -p --standard=PHPCompatibility --runtime-set testVersion 8.1 tests
- composer run-script phpcs -- -p --standard=PHPCompatibility --runtime-set testVersion 8.3 src
- composer run-script phpcs -- -p --standard=PHPCompatibility --runtime-set testVersion 8.3 tests
- They should all come back with no errors.