Avaiga / taipy-studio-config

Visual Studio Code extension for Taipy: Configuration Builder
Apache License 2.0
5 stars 1 forks source link

Show exposed type value and list of values for exposed type #46

Open FlorianJacta opened 1 year ago

FlorianJacta commented 1 year ago

Description The goal of this issue would be to always show the exposed type used for the Data node (Tabular Data nodes). We should also be able to see the list of predefined exposed types (pandas, modin) when we edit this property in order to change it easily without going in the documentation.

Acceptance Criteria

FredLL-Avaiga commented 1 year ago

I guess we'll have to add a non-restrictive enum to the exposed_type property @jrobinAV ? What would be the values then ? Is there a different set of value depending on the storage_type value ? From the description, I guess the value could also be a user defined python class ? "enum": [ "modin", "numpy", "pandas" (default), "" ]

FredLL-Avaiga commented 1 year ago

Does "always show the exposed type" mean that you want it to be shown by default in the details view of config @FlorianJacta ? Should the default value be explicitly "dataframe" or empty ?

FlorianJacta commented 1 year ago

Yes, that's it, in the details. I think it is an important property for this kind of Data nodes and it might make people understand how from a CSV we have a Pandas dataframe. It is also an essential information for the Data node. The list is 'pandas", 'modin', 'numpy'.

The default property should be 'pandas' but it also depends on the Default configuration of Data nodes of the user. So, I don't know how we can handle this. Am I right @jrobinAV ?

jrobinAV commented 5 months ago

Yes indeed, we should add the enum values into the schema.