Avaiga / taipy-studio-config

Visual Studio Code extension for Taipy: Configuration Builder
Apache License 2.0
6 stars 1 forks source link

Pipeline Node should not need to be connected to every task #57

Open AlexandreSajus opened 1 year ago

AlexandreSajus commented 1 year ago

Description We must connect the Pipeline Node to every Task Node we want to execute. This was misleading during beta testing: testers would forget to connect new tasks, and since the error logs don't explain much, they could not find what was wrong.

A tester expected that the pipeline should only be connected to the first Task Node, every Task Node connected indirectly to this first Task Node should also be executed like here: image

jrobinAV commented 1 year ago

I believe there is a misunderstanding of what is a Pipeline vs a Scenario. In Taipy 3.0 it should be simpler.

Basically, a pipeline is a subset of tasks that can be executed together independently from the other scenario tasks. When building your ScenarioConfig in studio, you want to define the sets of taskConfigs that belongs to the various PipelineConfigs created. There could be some taskConfig attacched to multiple PipelineConfigs and some TaskConfigs attached to zero pipelineConfig.

The proposal "the pipeline should only be connected to the first Task Node" does not make sense in this context.

Still the issue is interesting cause it shows that it is not intuitive. Probably both the Pipeline concept itself and Studio config are not intuitive regarding the usage of Pipeline. I would recommend at this stage, to simply remove the Pipeline Box and the Scenario Box.

What do you think ? @AlexandreSajus @FredLL-Avaiga @FlorianJacta @FabienLelaquais

AlexandreSajus commented 1 year ago

I agree. Removing the Pipeline Box and Scenario Box would make things more straightforward and more intuitive

FredLL-Avaiga commented 1 year ago

Shall we close this @AlexandreSajus @jrobinAV ?

jrobinAV commented 1 year ago

I don't know. A question has been raised. Do we want to remove the Pipeline box and the Scenario Box? Does it make sense for everyone?

FredLL-Avaiga commented 1 year ago

Not the scenario I suppose pipeline will go when we support 3.0?

On Wed, Jul 19, 2023, 12:07 Jean-Robin @.***> wrote:

I don't know. A question has been raised. Do we want to remove the Pipeline box and the Scenario Box? Does it make sense for everyone?

— Reply to this email directly, view it on GitHub https://github.com/Avaiga/taipy-studio-config/issues/57#issuecomment-1641803790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQBA5CP6FLFFERHVIVGLKLXQ6WUXANCNFSM6AAAAAAYOLDD6Y . You are receiving this because you were mentioned.Message ID: @.***>

AlexandreSajus commented 1 year ago

I don't know. A question has been raised. Do we want to remove the Pipeline box and the Scenario Box? Does it make sense for everyone?

In my mind, removing both of these would significantly improve accessibility which is the main bottleneck of Core currently.

jrobinAV commented 1 year ago

@FredLL-Avaiga Yes, removing the pipeline would be part of 3.0 anyway.

In 3.0 ScenarioConfig will directly hold TaskConfigs and some additional data node configs unrelated to any taskConfig.

If we keep the Scenario Box, that means it will be linked to all the task boxes and all the additional data node boxes. I guess it will degrade the accessibility a lot.

FabienLelaquais commented 1 year ago

If we use the link representation, yes. But we can change that, and add a 'Holding Scenario' label in the task and invent something for building the relationship. Now I suspect that tasks can be used by different scenario configs...

jrobinAV commented 1 year ago

Yes, both task configs and data node configs may be used by multiple Scenario configs...

Maybe the Scenario config can be displayed as a "title" of the graph displayed. I don't know. The difficulty would be on a global view with multiple scenario configs.

FlorianJacta commented 1 year ago

My first instinct was to create rectangles around scenarios like in the documentation but it has its limits. Or we could represent scenarios with different colors.

Maybe the global view should be not the main view and the user should be "forced/guided" to go to the scenario view (the default option).

jrobinAV commented 10 months ago

Up: I believe it's still relevant to remove the Scenario box from the graph. ARe we aligned on that?

FredLL-Avaiga commented 10 months ago

This issue is not relevant anymore Scenario node is still shown when the whole configuration is displayer It is not shown when the Scenario perspective is displayed

FlorianJacta commented 10 months ago

It is still relevant because you have to connect your scenario config to the tasks, right?

AlexandreSajus commented 10 months ago

Yeah, now the issue would be: either remove the scenario node (one toml file per scenario configuration) or do not make me connect the scenario node to each task

FredLL-Avaiga commented 10 months ago

The scenario node is not visible in the Scenario Perspective and every Task that is added to the perspective is added to the scenario

AlexandreSajus commented 10 months ago

Ah, I did not know that we did not have to connect tasks to the scenario node. Then it is fine. Maybe we should remove the scenario node then; what is its point?

FlorianJacta commented 10 months ago

I also think so! When creating a configuration we could ask for a scenario name directly and not propose to view the whole configuration by default.

Also, when I add data nodes to my page, it goes to _additionaldatanodes which is correct but they should disappear from this section if I attach them to a task. Is it an issue? I don't think this leads to any error however.

image

FredLL-Avaiga commented 10 months ago

task / additional_datanodes @jrobinAV do you confirm this is an issue ? If so, @FlorianJacta can you create another issue ?