search

AvaloniaUI / avalonia-docs

https://docs.avaloniaui.net/docs/welcome
64 stars 211 forks source link

Update displaying-images.md #552

Open Simusharp opened 1 month ago

Simusharp commented 1 month ago

There is a typo in the logic; it should IsVisible when IsNotNull

djeikyb commented 1 month ago

@Simusharp Are you sure about this change?

  1. This whole section is designed to teach IsNull as an intro to converters. This is not a typo-level mistake. It'd be surprising if it was this wrong for this long.
  2. If the IsNull in the code block is wrong, then it's probably also wrong in the paragraph that references the code block. You changed the code block but didn't address any of the corresponding tutorial text.
  3. Did you test this code change? I don't think there's any automation for testing tutorial code blocks, but it'd be good to know if you've validated the PR by running the code