Closed pepamartinec closed 2 years ago
Hello and thanks a lot for your PR !
I think that the message consumption should have a time limit (as stated in the docs) but you're right. I was wondering about a potential limit for SAS tokens, it looks like there is none and renewing them early is a good practice.
I like very much your refactoring about token generation and DSN parsing, thanks for that too. I'm merging this and I'll release a new minor version very soon.
Currently a SAS token is generated by
AzureHttpClientConfigurationBuilder
whenAzureTransport
is created, with default 1 hour expiration time. That basically means that when I runbin/console messenger:consume
, it can run for 1 hour and then fails with 403 error, because the SAS token expires.This change moves the token generation into the HTTP client, so a new token is generated for each request, allowing the consumer to run indefinitely (in theory).