search

AymDev / MessengerAzureBundle

A Symfony 4/5/6 bundle providing a Messenger transport for Azure Service Bus using the Azure REST API.
MIT License
10 stars 7 forks source link

Allow passing all supported configuration using DSN and options #14

Closed pepamartinec closed 9 months ago

pepamartinec commented 1 year ago

According to Messenger docs, transport options can be passed using both DSN and options config, which is not currently possible here.

This PR adds support for supplying any config using both DSN and options config. The implementation is heavily inspired by https://github.com/symfony/amazon-sqs-messenger/blob/6.3/Transport/Connection.php. If the same option is supplied multiple times, value is looked up in following order:

The implementation contains possible breaking change - originally the DSN was parsed using simple regex and values were then used as were. Now it uses parse_url + urldecode. This is again, to behave similarly as other transports does.

odinuv commented 11 months ago

@AymDev Hi, do you have an opinion on this ? Is it mergeable, or would you prefer done it otherwise ?

pepamartinec commented 10 months ago

Hi @AymDev. Any chance you can check this any time soon? So at least we know if there is any chance upstreaming the change.

Thank you.