Azure-Samples / ansible-playbooks

Ansible Playbook Samples for Azure
MIT License
224 stars 349 forks source link

Added sample playbooks for AKS #32

Closed caohai closed 5 years ago

caohai commented 6 years ago

Purpose

Does this introduce a breaking change?

Pull Request Type

What kind of change does this Pull Request introduce?

How to Test

$ pip install ansible[azure]
$ ansible-galaxy install Azure.azure_preview_modules
$ pip install -r ~/.ansible/roles/Azure.azure_preview_modules/files/requirements-azure.txt
git clone https://github.com/Azure-Samples/ansible-playbooks.git
cd ansible-playbooks
git checkout [branch-name]

What to Check

Verify that the playbook is successfully run.

Other Information

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

kyliel commented 6 years ago

How do you get resource group name? And don't list the complete SSH key in your sample.

caohai commented 6 years ago

@kyliel

kyliel commented 6 years ago

vm_create_ssh should be fixed too.

yuwzho commented 6 years ago

@kyliel @caohai The resource group is passed to playbook dynamically when running the test.

And the SSH, I don't think this is a problem writing in the playbook, since the public key can only be used paired with secret one.

caohai commented 6 years ago

@yuwzho Should I add back ssh-key or just keep it as it is?

yuwzho commented 6 years ago

@caohai I m not sure whether the invalid SSH can successfully create an AKS, could you please have a try? Otherwise, you can store the key in env, and retrieve it in the playbook