mysql sample updated - Githubissues

Azure-Samples / ansible-playbooks

Ansible Playbook Samples for Azure

MIT License

224 stars 349 forks source link

mysql sample updated #50

Open zikalino opened 5 years ago

zikalino commented 5 years ago

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Install ansible

$ pip install ansible[azure]

[Optional] Install ansible role

$ ansible-galaxy install Azure.azure_preview_modules
$ pip install -r ~/.ansible/roles/Azure.azure_preview_modules/files/requirements-azure.txt

Get the sample playbook

git clone https://github.com/Azure-Samples/ansible-playbooks.git
cd ansible-playbooks
git checkout [branch-name]

Test the code
```
ansible-playbook <filename>.yml
```

What to Check

Verify that the playbook is successfully run.

Other Information

kyliel commented 5 years ago

Below description is not correct. This playbook create a MySQL server and an instance of MySQL Database,

zikalino commented 5 years ago

@kyliel thanks! I will fix it

Fred-sun commented 5 years ago

@zikalino

Fred-sun commented 5 years ago

@zikalino, reviewers request change, Thanks!

Fred-sun commented 5 years ago

@zikalino Could you give a changed according by @yungezz's comment? Thanks!

Fred-sun commented 5 years ago

@zikalino

Fred-sun commented 5 years ago

@zikalino need you update

Fred-sun commented 5 years ago

kindly ping

Fred-sun commented 5 years ago

@zikalino need you udpate

Fred-sun commented 5 years ago

@zikalino Please help take a look this when you're available and push for merged. Thanks!

Fred-sun commented 5 years ago

@zikalino Please take a look this when you're available! Thanks!

Fred-sun commented 5 years ago

@zikalino Please help take a look this PR when you're available! Thanks!

Fred-sun commented 5 years ago

@zikalino

Fred-sun commented 5 years ago

kindly ping

Fred-sun commented 5 years ago

@zikalino @zikalino Please change this PR according by above comments? Thanks!

Fred-sun commented 5 years ago

@zikalino

Fred-sun commented 5 years ago

@zikalino Please update the PR according by the above comment? Push this to review! Thank you very much!

Fred-sun commented 5 years ago

@zikalino need you changed! Thanks a lot!

Fred-sun commented 5 years ago

@zikalino

Fred-sun commented 4 years ago

@zikalino Need you to change! Please update when you're free! Thank you very much!

Fred-sun commented 4 years ago

@zikalino This PR has been open for a long time, please follow the comments to change and promote the review. Thank you very much!

Fred-sun commented 4 years ago

@zikalino How will this PR be handled? hasn't been updated in a long time. Please check, thank you very much!

Fred-sun commented 4 years ago

@zikalino Please help finish PR changed and push for review when you're free! Thanks a lot!

Fred-sun commented 4 years ago

@zikalino Please help update this PR when you're free! Thank you very much!

Fred-sun commented 4 years ago

kindly ping

Fred-sun commented 4 years ago

@zikalino Can you help complete the change of PR and promote the merger? It's been around for a long time--Not much to change!. Thank you very much!

Fred-sun commented 4 years ago

@zikalino Thank you for taking the time to contribute to this PR. We will transfer ansible 's azure module related Issue and PR to azure collection (https://github.com/ansible-collections/azure/pulls), can you transfer the Issue to azure collection repo?