added steps required to run this playbook

Azure-Samples / ansible-playbooks

Ansible Playbook Samples for Azure

MIT License

229 stars 349 forks source link

added steps required to run this playbook #54

Closed ashishrajsrivastava closed 5 years ago

ashishrajsrivastava commented 5 years ago

Purpose

Added steps required to run playbook create_virtualmachine_with_subnet_in_different_resource_group.yml. Closes #49

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

How to Test

Install ansible

$ pip install ansible[azure]

[Optional] Install ansible role

$ ansible-galaxy install Azure.azure_preview_modules
$ pip install -r ~/.ansible/roles/Azure.azure_preview_modules/files/requirements-azure.txt

Get the sample playbook

git clone https://github.com/Azure-Samples/ansible-playbooks.git
cd ansible-playbooks
git checkout [branch-name]

Test the code
```
ansible-playbook <filename>.yml
```

What to Check

Verify that the playbook is successfully run.

Other Information

Fred-sun commented 5 years ago

@zikalino Could you help to review this PR? This PR add documentation to fixed #49, Thanks!

Fred-sun commented 5 years ago

@ashishrajsrivastava Thanks for your contribution, Could you recheck this PR according by yuwzho's comment? thanks!

msftclas commented 5 years ago

All CLA requirements met.

Fred-sun commented 5 years ago

@yuwzho

ashishrajsrivastava commented 5 years ago

will be adding Ansible extension for Visual Studio code steps in readme as a part of another PR.

yuwzho commented 5 years ago

If installing Ansible extension, there is no need to install the Azure account extension. @yungezz Please correct me if anything wrong

yungezz commented 5 years ago

you'll still need install azure account extension if you want to run playbook in cloudshell with VSCode. Ansible extension doesn't bundle any other extension. User instsall azure account extension per need.

ashishrajsrivastava commented 5 years ago

Yep to be able to run it in cloud shell in vscode user will have to install azure account extension too. If user opts for other execution target like docker,local ansible or via ssh then azure account extension will not be needed but then user will have to configure the authentication environment in respective options himself.

Fred-sun commented 5 years ago

@yuwzho @yungezz Could you help confirm that how about the PR going ahead? merged or further review? Thanks!

yuwzho commented 5 years ago

@ashishrajsrivastava Thanks for your pr, sorry about the late response.