Azure-Samples / ansible-playbooks

Ansible Playbook Samples for Azure
MIT License
229 stars 349 forks source link

Adding support for 2.8 #74

Closed imjoseangel closed 5 years ago

imjoseangel commented 5 years ago

Purpose

Does this introduce a breaking change?

Pull Request Type

What kind of change does this Pull Request introduce?

How to Test

$ pip install ansible[azure]
$ ansible-galaxy install azure.azure_preview_modules
$ pip install -r ~/.ansible/roles/azure.azure_preview_modules/files/requirements-azure.txt
git clone https://github.com/Azure-Samples/ansible-playbooks.git
cd ansible-playbooks
git checkout [branch-name]

What to Check

Verify that the playbook is successfully run.

TASK [Create VM Extension] *************************************************************************************************************************************************************

changed: [localhost]

TASK [Stop VM before it can be generalized and image captured] *************************************************************************************************************************
changed: [localhost]

TASK [Generalize VM using version >= 2.8] **********************************************************************************************************************************************
changed: [localhost]

TASK [Create an image from a virtual machine] ******************************************************************************************************************************************
changed: [localhost]

Other Information

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

Fred-sun commented 5 years ago

ready_for_review

Fred-sun commented 5 years ago

@yungezz @zikalino @yuwzho @MyronFanQiu Please take a review this PR when you're free! Thanks a lot!

imjoseangel commented 5 years ago

Hey! How is this going? Could you please review? Thanks!

zikalino commented 5 years ago

Looks great! Thank you for contribution @imjoseangel