Feature(frontend): tooltips + prettier

Azure-Samples / azure-search-openai-demo-java

This repo is the Java version of Microsoft's sample app for ChatGPT + Enterprise data.

MIT License

67 stars 66 forks source link

Feature(frontend): tooltips + prettier #46

Closed diberry closed 7 months ago

diberry commented 8 months ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

Other Information

dantelmomsft commented 8 months ago

@johnoliver can you have a look and see if changes are required or if this is going to create UI regression in case we merge #44

johnoliver commented 7 months ago

After the conflicts are resolved it seems to compile ok, and I am fine with the code in general, however testing I cannot see the tooltips within the UI, is this PR still functional since the recent UI updates? @diberry

diberry commented 7 months ago

@johnoliver I'm not sure what the recent UI updates are. I'll take a look and see if this is still relevant. Can you leave open for a few days?

johnoliver commented 7 months ago

@johnoliver I'm not sure what the recent UI updates are. I'll take a look and see if this is still relevant. Can you leave open for a few days?

Yeah of course, no problem

brunoborges commented 7 months ago

Hey @diberry we spoke about this today. Let us know when it is ready for review.