search

Azure / azure-functions-signalrservice-extension

Azure Functions bindings for SignalR Service. Project moved to https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService .
MIT License
97 stars 46 forks source link

Generic Serverless Hub for Typed Client Proxy #264

Closed phantomcosmonaut closed 2 years ago

phantomcosmonaut commented 2 years ago

Copied TypedClientBuilder code from aspnetcore/signalr and created a TypedHubClients<T> wrapper for IHubClients<T> that allows for a generic version of ServerlessHub accepting a custom typed client proxy.

See https://github.com/Azure/azure-functions-signalrservice-extension/issues/131

Y-Sindo commented 2 years ago

Thanks for your commit. I think it is better to implement TypedClientProxy from the Azure SignalR Management SDK/Serverless SDK side so that we don't need to copy source code from ASP.NET CORE. Serverless SDK is the core dependency of SignalR extension. Actually we had a PR on this, but at that time we were refactoring the whole serverless SDK, so we didn't accept it. We will put this issue into our backlog and we also welcome you to contribute on this.

phantomcosmonaut commented 2 years ago

@Y-Sindo Ok, thanks for the feedback. I'll wait until I see this in the backlog

Y-Sindo commented 2 years ago

Here is the issue in Serverless SDK: https://github.com/Azure/azure-signalr/issues/1033