search

Azure / simdem

Tool for Simulating Demo's, delivering Tutorials and using documentation as tests.
MIT License
34 stars 17 forks source link

Jamesser dev #119

Closed jasonmesser7 closed 2 years ago

jasonmesser7 commented 2 years ago

This branch contains 4 primary changes.

  1. Changes to CircleCI config.yml file which allows for testing of Azure resources
  2. Edits to the test folder which sets up a resource group, uses that for whatever content is in the AzureTests subfolder, and then deletes it after the tests are ran.
  3. Changes to AKSDeployment quick start guide. Made it a lot more like documentation which descriptions for what everything is doing
  4. Addition of envsubst in requirements.txt which is critical for running the AKSDeployment file.
rgardler-msft commented 2 years ago

Other than one minor change (see above comments) this LGTM and is ready to merge

jasonmesser7 commented 2 years ago

Alright, made the final changes and will perform the squash and merge. Thanks for reviewing and for your feedback.