search

Azure / simdem

Tool for Simulating Demo's, delivering Tutorials and using documentation as tests.
MIT License
34 stars 17 forks source link

adding a test case for #120 #121

Closed jasonmesser7 closed 2 years ago

jasonmesser7 commented 2 years ago

@rgardler-msft Changes look good to me. In this case should we squash and merge or create a merge commit?

rgardler-msft commented 2 years ago

Well I broke the feature branch rule in that my README commit is not relevant to the feature here. Ignoring that the two commits are valuable in isolation and so I would commit without squashing on this one.

Technically we should cherry pick and make the README a separate PR. But it is inconsequential (I actually only did it to ensure Git was going to let me commit after I changed my Git user).

I'll just go ahead and merge.