Closed jasonmesser7 closed 2 years ago
It would be better to do this work in a fork of their repo so that we can track the required changes and issue PR requests when appropriate. This may require a change in SimDem, if so let's raise an issue.
Leaving this PR here though so that we can work on this copy in case any changes are needed.
Am I right in thinking we are pushing these changes into the upstream repo? If so should we close this PR?
Yup, that makes sense to me given the current plan to implement changes in the open source labs. Let me close the PR.
I copied the entire raw lab from https://github.com/Azure-Samples/azure-opensource-labs/blob/main/cloud-native/containerapps-python-fastapi/README.md and then made changes to make sure that this tutorial works in simdem.