Azure / simdem

Tool for Simulating Demo's, delivering Tutorials and using documentation as tests.
MIT License
34 stars 17 forks source link

Container apps oss labs #133

Open colinmixonn opened 2 years ago

colinmixonn commented 2 years ago

I was unclear what commands to include for azure login so I know that needs to be included before merging into main.

Runs successfully in my tests from beginning to end

rgardler-msft commented 2 years ago

This is an OSS Labs document, we should not be forking it into our repo. It should go into the upstream repo. Lets review it here first, but not merge here.

colinmixonn commented 2 years ago

Currently stuck on avoiding hardcoding the users GitHub username in the .json file. I've read that .json files dont accept variables. Example below.

"GITHUB_USER_OR_OR": "colinmixonn", "CONTAINER_IMAGE":"ghcr.io/colinmixonn/serverless-python:release",