Azure / simdem

Tool for Simulating Demo's, delivering Tutorials and using documentation as tests.

MIT License

34 stars 16 forks source link

SimDem 2: Migration to Master branch #98

Open lastcoolnameleft opened 6 years ago

lastcoolnameleft commented 6 years ago

I'd like to finalize a list of required features/issues that need to be resolved so that we can merge the simdem2 branch into master.

@rgardler and I had a meeting months ago to create this list and I believe that the only high Priority issue left is:

https://github.com/Azure/simdem/issues/92 - Inject env vars

Anything else?

lastcoolnameleft commented 6 years ago

Just thought of one:

Implement Circle CI integration.

SorraTheOrc commented 6 years ago

100 (Validation section not run)

SorraTheOrc commented 6 years ago

I've been working on a new set of real world scripts using SimDem1. They can be found in http://github.com/Azure/Moodle/docs. If they run in test, tutorial and demo modes then I would consider this issue closed.

I'm will test them during ongoing development in SimDem2 and raise issues as I come across them.

SorraTheOrc commented 6 years ago

Update version number to match released version numbering. Suggest 0.9.0 as the first version.

lastcoolnameleft commented 6 years ago

Here's the update:

https://github.com/Azure/simdem/issues/92 is closed
https://circleci.com/gh/Azure/simdem/184 now passes
https://github.com/Azure/simdem/issues/100 is awaiting approval
https://github.com/Azure/simdem/blob/simdem2/setup.py#L17 now points to 0.9.0

Any other changes necessary before we migrate to the master branch @rgardler ?

SorraTheOrc commented 6 years ago

It's going to be hard to track all this in multiple comments so lets create a list of things to check off...

[ ] Test against http://github.com/Azure/Moodle/docs
[ ] Test against https://github.com/Azure/Moodle/tree/managedapplication/managedApplication
[ ] Test against https://github.com/Azure/Moodle/tree/master/loadtest
[ ] Test against SimDem1 tests moving tests to here (examples directory) and raising any issues for tests that do not currently pass P-High issues should only be raised for items that must be implemented ahead of merge
[ ] Test against SimDem1 [documentation] (https://github.com/Azure/simdem/tree/master/demo_scripts/simdem) moving appropriate content into documentation here, raising issues for features that are not yet implemented P-High issues should only be raised for items that must be implemented ahead of merge
[ ] Fix all P-High issues

SorraTheOrc commented 6 years ago

I'm embarking on all the testing described above, and will tick things off when completed.

SorraTheOrc commented 6 years ago

I feel I'm blocking progress by my inactivity. I still use SimDem and thus I'm selfishly wanting all my existing docs to work in v2. Hence my insistence on testing.

However, I'm not doing the testing and instead continuing to work in v1.

Please tag the repo and go ahead with this merge. It's time I was forced to do the right thing and move to v2.