search

Azure / terraform-azurerm-avm-res-web-site

MIT License
9 stars 6 forks source link

[AVM Module Issue]: slot_custom_hostname_binding #101

Closed rbradley51 closed 1 month ago

rbradley51 commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

@donovm4 could you add support for binding a custom hostname and certificate to a slot?

donovm4 commented 1 month ago

@rbradley51 - will take a look into this shortly.

donovm4 commented 1 month ago

@rbradley51 - please review the latest published release v0.8.0

donovm4 commented 1 month ago

I will likely need to revamp the documentation to detail slot_as_target better, but wanted to get it out for testing before closing this issue

rbradley51 commented 1 month ago

@donovm4 - when adding the slot, it doesn't look for azurerm_windows_web_app_slot

image

donovm4 commented 1 month ago

@rbradley51 - apologies, let me try to get a quick fix in for that.

donovm4 commented 1 month ago

@rbradley51 - the v0.8.1 update is published, with some additional functionality in case you need to reuse a certificate or thumbprint across multiple module calls.

rbradley51 commented 1 month ago

@donovm4 - I was able to get the cert, using key_vault_id, and domain set on the slot.

azurerm_dns_txt_record doesn't let you call the rg by resource_id, so I can't add a record to a zone in a different sub. maybe they'll add resource_group_id in a later release.

donovm4 commented 1 month ago

@rbradley51 - alright! thank you for your feedback. feel free to drop a feature request once that capability is made possible (if it hasn't been implemented here)