search

Azure / terraform-azurerm-avm-res-web-site

MIT License
17 stars 10 forks source link

[AVM Module Issue]: minimum_tls_version has missing latest 1.3 version #136

Closed kborowiec-mag closed 1 week ago

kborowiec-mag commented 3 weeks ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

minimum tls version cannot be set to recent 1.3

Error: expected site_config.0.minimum_tls_version to be one of ["1.1" "1.2" "1.0"], got 1.3 │ │ with module.function_appname.azurerm_linux_function_app.this[0], │ on .terraform\modules\function_appname\main.function_app.tf line 463, in resource "azurerm_linux_function_app" "this": │ 463: minimum_tls_version = var.site_config.minimum_tls_version

donovm4 commented 3 weeks ago

Hello @kborowiec-mag :

Thank you - I will look into this shortly.

donovm4 commented 3 weeks ago

@kborowiec-mag :

It appears that you will need to use azurerm v4.8, but this module does not yet support azurerm v4.x (see related Issue #122).

I am preparing to release v0.12.0 of the module, which will support azurerm v4.x, but will have a breaking change no longer supporting azurerm v3.x.

I will mark this as a feature request instead of a bug and provide an update when v0.12.0 has been released.

donovm4 commented 2 weeks ago

@kborowiec-mag :

Please see release 0.12.0 of the module and review all release notes. This release focuses on azurerm 4.x support, which will enable tls 1.3 for app service through azurerm 4.8.

Consider reaching out or reopening this issue if you run into any problems.