search

Azure / terraform-azurerm-avm-res-web-site

MIT License
17 stars 10 forks source link

[AVM Module Issue]: #61

Open vjmanda opened 6 months ago

vjmanda commented 6 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Feature request

Allow configuring private endpoints for the function app's backend storage account.

Description

The module currently only permits creating the function app's backend storage account publicly with no restrictions. This is the case even when the function app is configured with private endpoints.

Ideally the module should permit the function app to connect to the backend storage account privately using private endpoint connectivity.

donovm4 commented 6 months ago

Hi @vjmanda - I am currently working on a pattern module for function apps using secured storage. I believe the current workaround would be to leverage the function app resource module along with the storage account resource module.

vjmanda commented 6 months ago

Hi @vjmanda - I am currently working on a pattern module for function apps using secured storage. I believe the current workaround would be to leverage the function app resource module along with the storage account resource module.

@donovm4 - Should it be a pattern module though just to connect from the function app to backend storage securely?

donovm4 commented 6 months ago

@vjmanda - one of the main factors for a pattern module being created is to aligned with this quickstart template for creating a Function App with private endpoint-secured Storage.

From my understanding, it would also be outside of the scope / spec to load up the resource module for function apps / web apps with all of the possible configurations / inputs for a storage account included, as it would overlap with a lot of the work already done for the separate existing resource module.

In this case, the separate resource modules for a storage account and function app have already been developed, so it would be easier to reference both modules individually to work together or use a pattern for a common task involving these resources, rather than duplicate the capabilities of the storage account module into the function app module.

Here is the original proposal

Feel free to open up an issue on AVM GitHub if you would like to provide feedback / insight on this particular issue.

vjmanda commented 6 months ago

Thanks @donovm4 - I will take a look at the pattern module proposal.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01TF.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01TF.

microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02TF.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01TF.

microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02TF.

donovm4 commented 5 months ago

This module is still in development, and will be running through a code review in the near future