B2Bitcoin / beBOP

Marvelous p2p bitcoin-based online sales platform
https://be-bop.io
GNU Affero General Public License v3.0
16 stars 3 forks source link

🦋 Allow overwrite of non-POS, non-bank transfer payment on POS session #1570

Open Tirodem opened 1 week ago

Tirodem commented 1 week ago

Tonight we had to make a B2B order with Lightning, and I had to change the payment expiration manually to few days. Same case happened earlier this week.

CB, Lightning and BTC on-chain have expiration.

When you do order as POS, it's either :

Currently, the value comes from here : image

To answer our case, we need something like this on POS /checkout : image field has default value and is disabled if check is unchecked image field is now editable once check is checked

You must not display nor save the value if payment is a current payment with no expiration (bank-transfer, point-of-sale).

By the way, if display, it must be required. Currently, on /admin/config, you can save if empty, and it'll be zero. Value must be at least 1.

Tirodem commented 1 week ago

@coyotte508 any objection or warning ?