🦋 Add credit card payment on pos session on /checkout

[Tirodem]

As said, even is POS sales on retail physical shop are not MVP, POS session can be used for personal shopper use, so we need to add credit card payment (1st on list).

[coyotte508]

To be clear this is "retail card" right? Or real credit card payments?

[Tirodem]

Nice one, thanks for the question. We need the sumup online card (mvp), and the sumup physical the card (in the future). So right now I want the website card on pos session.

Le dim. 10 déc. 2023 à 00:53, Eliott C. @.***> a écrit :

To be clear this is "retail card" right? Or real credit card payments?

— Reply to this email directly, view it on GitHub https://github.com/B2Bitcoin/beBOP/issues/755#issuecomment-1848784778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7BKPUC6E5MLFY37NXAIFDYIT2WNAVCNFSM6AAAAABAOB5GESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYG44DINZXHA . You are receiving this because you authored the thread.Message ID: @.***>

[coyotte508]

ok this is a one line fix:

...(isSumupEnabled() && role !== POS_ROLE_ID ? (['card'] as const) : []),

remove the condition on POS_ROLE_ID

I just don't understand why the buyer would use a POS session in that case

[Tirodem]

currently pos session leads to additional options like vat exception, manual discount, access to pos only product with personal shopper philosophy, someone can call luxogood, tell thel "i want 3 models + 2 customs I cannot buy through website, I'll go fetch them at your place and pay by credit card" with pos session you can prepare this order, put the customer contact, they'll receive their payment link through order url, pay, and benefits from discounts and exclusive articles compared to a web experience and it's better to have this on pos session and not every employee session

Le dim. 10 déc. 2023 à 00:56, Eliott C. @.***> a écrit :

ok this is a one line fix:

...(isSumupEnabled() && role !== POS_ROLE_ID ? (['card'] as const) : []),

remove the condition on POS_ROLE_ID

I just don't understand why the buyer would use a POS session in that case

— Reply to this email directly, view it on GitHub https://github.com/B2Bitcoin/beBOP/issues/755#issuecomment-1848785414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7BKPXKOCVD2SGXOUWXNWDYIT3ENAVCNFSM6AAAAABAOB5GESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYG44DKNBRGQ . You are receiving this because you authored the thread.Message ID: @.***>

[coyotte508]

@ithiame taking this (need for tests)

[coyotte508]

done in #771 as side-effect

but it's weird to have "card" as first option on a POS account when it's the online card & not retail card (but ok for MVP I guess)