search

BBVAEngineering / ember-network-state

Check and react on network state of your progressive web app
MIT License
21 stars 4 forks source link

Allow to specify the mode on the fetch request #124

Closed colenso closed 2 years ago

colenso commented 3 years ago

Is helpful if one wants to set the mode to no-cors like I had to as per my requirement.

adrigzr commented 3 years ago

Hi @colenso,

Thanks for your PR! Could you please add some documentation in the README and change the commit message to follow our commit convention to be able to release a valid version? It could be something like:

feat: add `mode` option to fetch

Thank you again!

colenso commented 2 years ago

Sorry. I hadn't seen this. I'll make the requested changes now.

colenso commented 2 years ago

Closing this in favor of https://github.com/BBVAEngineering/ember-network-state/pull/136