Open lnnrtwttkhn opened 8 months ago
Thanks @lnnrtwttkhn for the thorough feedback. @RabeaMue do you have time to implement these? Let me know what I can do to support!
@HeidiSeibold Yes, I am editing the points from the feedback now and sending you a pull request. Thank you @lnnrtwttkhn !
hi @HeidiSeibold and @RabeaMue,
here is my feedback on the version control chapter. overall, I think it gives a very nice short introduction to the basic functions and commands of Git. below are a few thoughts that I had while reading through the chapter. feel free to ignore them, if you think they are not relevant to your target audience. I didn't make any changes re grammar or style because this would be somewhat opinionated anyways (but I added automated typo fixing, see #5). let me know if anything is unclear! great work!
README.md
and especially the.gitignore
file could be explained in a bit more detail, if you recommend to add them when creating a new repo on GitHubgit status
git add .
it's might be not clear what "Stage" in "Stage the changed files:" means.git add .
, i.e., adding all changes instead of staging / committing more selectively e.g., usinggit add FILE