search

BGforgeNet / FO2tweaks

Fallout 2 tweaks
https://forums.bgforge.net/viewforum.php?f=26
122 stars 11 forks source link

Dogmeat still checks for party limit #41

Closed Taberone closed 4 years ago

Taberone commented 5 years ago

Describe the bug Dogmeat still checks for party size before joining.

To Reproduce Steps to reproduce the behavior:

  1. Go over the party limit with "unlimited companions" enabled.
  2. Try to recruit Dogmeat. Either when you first meet him, or after you tell him to stay and come back while over the party limit.
  3. You can't.

Expected behavior Recruit Dogmeat regardless of party size.

Screenshots image

FO2tweaks version 9.5

Sfall version Unknown. FO2Tweaks doesn't come with it's own ddraw.ini so I don't know what SFall I'm using. At the very least, I think it's 4.1.2+. Might be 4.1.2.8.

Other mods and patches F2WR (+ additional weapon changes made in F2Wedit) and Restoration Project

Debug.log Enable debug.log as described here, reproduce the issue and attach the resulting log.

sfall-log.txt

burner1024 commented 4 years ago

Please share the log again.

Taberone commented 4 years ago

Github won't let me drag and drop (error) so have the Pastebin link instead https://pastebin.com/KY6Q2zLj

burner1024 commented 4 years ago

Dammit, this is annoying. Do you have another save to try, by chance?

Taberone commented 4 years ago

Unfortunately, nope.

burner1024 commented 4 years ago

Link to data archive is dead. It's really best to attach to github issue itself.

Taberone commented 4 years ago

data.zip Figured out why Github won't let me drag and drop: BitDefender keeps giving false positives about viruses, apparently. This should do.

Honestly, at some point I'm probably gonna have to reinstall FO2. My installation is such a jumbled mess.

burner1024 commented 4 years ago

@Taberone still can't load, but don't worry, I figured another way to test.

@FakelsHub ну вот собственно и появилась нужда в случае, про который я говорил выше: исполнение после хэндлера. Если персонаж в броне, то собака просто рычит и в диалог не заходит вообще. При этом talk_p_proc исполняется. Таким образом, напарники из группы дропаются, а обратно уже не попадают.

FakelsHub commented 4 years ago

Непонял про собаку в броне. Можно видео? А Крючек game mode срабатывает? По нему обратно присоединяй как и раньше.

burner1024 commented 4 years ago

Собака не в броне. Персонаж в броне. Собака при этом просто не разговаривает. Снимаешь броню, она видит костюм, тогда с ней можно говорить. А если она не разговаривает, то и режим не меняется. Хотя я тут подумал, можно наверное в первом хендлере проверять есть ли броня, чисто для собаки...

FakelsHub commented 4 years ago

Хотя я тут подумал, можно наверное в первом хендлере проверять есть ли броня, чисто для собаки...

👍

burner1024 commented 4 years ago

@FakelsHub так и сделал, но это частный случай, в общем не всегда так получится обработать.

@Taberone attached is the script that should really-really work, plus 4.2 ddraw.dll, to make sure it's the same version (I had another one for some reason, it might've been reuploaded to sourceforge.) gl_g_unlimited_party.int.zip

Taberone commented 4 years ago

That worked! Thank you.

burner1024 commented 4 years ago

Great, finally.