allemangD commented 4 years ago

The checklist below is completed using the branch for PR #131. Some notes are included in bold italic.

Checklist

Click means Left-Click

Data, Units and default values

Start application, and check:

[x] Atlas and ontology are loaded
[x] Unit displayed in Annotation Thickness, Slice Step Size and Slice offset boxes is um
[x] Exploration mode is selected
[x] Structure ontology is selected
[x] Slice Step Size is 25
[x] Reset button is enabled
[x] Apply button is disabled
[x] Annotation Type is Spline
[ ] Filename text box is None Text box is initially empty
[x] Coronal reference view is selected

Reset view using CTRL+W, restart the application and check:

[ ] Unit displayed in Annotation Thickness, Slice Step Size and Slice offset boxes is um Known Issues: #89 Ctrl+W removes all objects from the 3d view.

Ontology combo box

located in the lower left corner

[x] Check that Ontology is visible in 2D and 3D views
[x] Select Layer -> Check that 2D and 3D views are updated
[x] Select None -> idem

DataProbe

located in status bar, right of Ontology combo box

[ ] Mouse over slice in 2D view -> Confirm coordinate and structure name are displayed
[ ] Select Layer ontology -> Mouse over slice in 2D view -> Check that layer name are displayed Probe data does not appear.

Contrast slider

[x] Select None in ontology combo box
[x] Click in between min/max and hold -> move mouse to translate range -> Check that 2D and 3D views are updated
[x] Click on handle min handle -> move mouse -> max handle should be symmetrically updated -> Check that 2D and 3D views are updated
[ ] Click Reset button -> Check min/max are set -> Check that 2D and 3D views are updated HomeWidget has no attribute DefaultWindowLevelMin

ReferenceView combo box

[x] Select Axial -> 2D and 3D views are updated and have same orientation
[x] Select Sagittal -> idem
[x] Select Coronal -> idem

"Adjust Slice Viewer FOV" button

located on the left of the Reference View combo box

[ ] Select "Coronal" -> Move slider -> Click on button -> expected offset is 6600 -> 2D and 3D views are updated Value is -6575. Views are updated, and visibility is similar to what's expected.
[x] Select "Axial" -> idem -3975 -> idem
[x] Select "Sagittal" -> idem 5699 -> idem

Slice offset slider

[x] Move Slider -> check that TextBox, 2D and 3D views are updated
[x] Use mouse wheel in 2D view -> check that Slider, TextBox, 2D and 3D views are updated
[x] Enter value in TextBox -> check that Slider, 2D and 3D view are updated. Known issues: #73

Slice Step Size slider

[x] Set Slice Step Size to 5
2D view
- [x] Click once on 2D view -> use right&left arrow -> check slice offset is updated by 5 increment in 2D and 3D views updated
- [x] Click once on 2D view -> move mouse cursor outside of 2D view -> use right&left arrow -> idem
3D view
- [x] Click once on 3D view slice plane -> use right&left arrow -> check slice offset is updated by 5 increment, 2D and 3D views updated. Known issues: #83
- [ ] Click once on 3D view slice plane -> move mouse cursor outside slice plane -> use right&left arrow -> nothing happen. Known issues: #84 This rotates the 3D view.
- [x] Use mouse wheel to zoom in until no background is visible -> move mouse cursor outside -> use right&left arrow -> check slice offset updated by 5 increment in 2D and 3D views updated. Known issues: #83

Roll/Pitch/Yaw sliders

[x] Move Roll, Pitch and Yaw sliders -> Apply button is enabled -> wait few seconds, no update should happen -> click Apply -> 2D and 3D views should be updated
[x] Click Reset -> Raw/Pitch/Yaw reset to 0 -> Apply button disabled, slice offset set to 6600
[ ] Update Roll, Pitch, Yaw spin boxes with 25, 35 and 50 -> wait few seconds, nothing should happen -> click Apply -> 2D and 3D views should be updated, slice offset is set to 9478.087 Value is -9472.2612. All other behavior is expected.
[x] Click Reset
[x] Move Roll slider -> wait few seconds, no update should happen -> press Enter or Return -> 2D and 3D views should be updated
[x] Move Pitch slider -> idem
[x] Move Yaw slider -> idem
[x] Update Roll spin box -> wait few seconds, no update should happen -> press Enter or Return -> 2D and 3D views should be updated
[x] Update Pitch spin box -> idem
[x] Update Yaw spin box -> idem

3D View

[x] Click and hold outside slice plane + move mouse cursor -> camera is updated
[x] Click and hold on slice plane + move mouse cursor -> slice offset is updated
[x] Click and hold on slice plane red orthogonal arrow + move mouse cursor -> raw/pitch/yaw are updated, slice offset is updated -> Apply button is disabled

Annotation creation and updates (Edit mode vs Exploration mode)

[x] Select Place mode -> Click on slice plane in 3D view -> nothing happen
[x] Click once on 2D view -> Annotation point is added -> click multiple time -> annotation is created
[x] Right click on 2D view -> Edit mode is selected
[x] Select Edit mode -> Click on 2D view -> nothing happens
[x] Select Edit mode -> Click and hold annotation point -> move mouse cursor -> point position is updated
[ ] Click and hold near annotation line and away of point -> move mouse cursor -> entire annotation is moved
Update slice offset
- [x] Using slider -> annotation position is updated
- [x] Using right&left arrow -> idem
- [x] Click and hold on image slice plane in 3D, move mouse -> idem
Update raw/pitch/yaw
- [x] Click and hold on slice plane red orthogonal arrow in 3D view + move mouse cursor -> annotation position is updated
- [x] Update Roll/Pitch/Yaw text boxes -> idem
[x] Select Exploration mode -> annotation point or line can NOT be selected and translated
[x] Select Edit mode -> annotation point or line can be updated

Keyboard Accelerators and Mouse Operations

See https://github.com/BICCN/cell-locator#keyboard-accelerators-and-mouse-operations

[ ] Check General
[x] Check 2D Viewer
[x] Check 2D Viewer / Zoom and Pan
[ ] Check 2D Viewer / Annotation
[x] Check 3D Viewer
[x] Check SpinBoxes and Sliders

Annotation Type

[x] Set Annotation Type to Spline
[x] Select Edit mode -> Create an annotation
[x] Select PolyLine -> Annotation type is updated in 2D and 3D views
[x] Add annotation point -> annotation type should remain the same

Annotation Thickness

[x] Select Edit mode -> Add at least 3 points -> Update thickness -> 3D view annotation thickness is updated

Confirm Exit Dialog

[x] Start application -> Close application -> No confirmation dialog -> Application is closed
[ ] Start application -> Update camera, update slice offset, reset FOV -> Close application -> No confirmation dialog -> Application is closed
[x] Start application -> Select Edit mode -> Add points
[x] Close application -> Confirmation dialog -> Click "Cancel exit" -> Nothing happen
[x] Close application -> Confirmation dialog -> Click "Save" -> Save Dialog show -> Click Cancel -> Application stays open
[ ] Close application -> Confirmation dialog -> Click "Save" -> Save Dialog show -> Select location -> Click Save -> Application is closed
[x] Start application -> Select Edit mode -> Add points -> Close application -> Confirmation dialog -> Click "Exit (discard modification)" -> Exit without saving annotation -> Application is closed

Check current filename is displayed

Clicking "New" causes all objects to be removed from both 2D and 3D views.

[ ] Click New -> Enter annotation.json -> Click Save -> Check that filename text box displays /path/to/annotation.json
[ ] Click New -> Enter annotation2.json -> Click Save -> Check that filename text box displays /path/to/annotation2.json
[x] Click Load -> Select annotation.json -> Click Load -> Check that filename text box displays /path/to/annotation.json
[ ] Click SaveAs -> Enter annotation3.json-> Click Save -> Check that filename text box displays /path/to/annotation3.json This updates the location internally, so that "Save" button works correctly, but does not update the text box.

Test Cancelling New/SaveAs/Load is a no-op

[ ] Click New -> Click Cancel -> Click Save -> Existing annotation should be saved without showing "Save As" dialog
[x] Click SaveAs -> idem
[x] Click Load -> idem
[x] Click SaveAs -> Check that "Save As" dialog is shown

Test Save -> New -> Load -> Save

Create annotation:

[x] Start application -> Set ReferenceView to Sagittal
[x] Select Edit mode -> Add 3 points
[x] Set properties
- Raw/Pitch/Yaw set to 10/20/30
- Slice Step Size to 10
- Annotation thickness to 60
- Annotation Type to PolyLine
[x] Click Save -> popup -> Enter annotation.json -> Click Save

Then:

Unable to choose "New" or Ctrl+W as mentioned above. Closing, re-opening the application, and loading the above annotation functions as expected.

[ ] Click New -> popup -> Enter annotation2.json -> Click Save -> Click Reset -> Set Reference View to Axial
[ ] Click Load -> Check that properties match the one entered above -> Update Roll/Pitch/Yaw then select Edit mode and confirm the annotation is snapped back.
[ ] CTRL + W -> Application state is reset -> Click Load -> Check that properties match the ones entered above
[ ] Close Application -> no confirmation dialog expected -> Start application -> Click Load -> Check that properties match the ones entered above Known issues: #87
[ ] Click SaveAs -> Enter annotation3.json -> Click Save

Check that file annotation.json and annotation3.json are:

[ ] identical Known issues: #78
[ ] quasi-identical expect numerical precisions

Remembering directory used for last saving

[ ] Start application -> Click Save -> Choose a different directory -> Choose Save -> Close application
[ ] Start application -> Click Save -> Check suggest directory is the one of previous step
[ ] Start application -> Click Load -> idem

Remembering directory used for last loading

[ ] Move annotation.json created in previous step onto the Desktop
[ ] Delete application settings directory (Running CellLocator --settings-path allows to get the directory)
[ ] Start application -> Click Load -> Document directory should be selected
- Navigate to Desktop -> Select annotation.json -> Choose Load
- Click Load -> Desktop directory should be selected -> Close application
[ ] Start application -> Click Load -> Desktop directory should be selected