search

BIT-Studio-3 / Space-Rescue

Space game for PC - Student project
MIT License
5 stars 1 forks source link

On planet rotation #187

Closed 3MKJOE58 closed 1 year ago

3MKJOE58 commented 1 year ago

Adding on planet rotation

PBWiseman commented 1 year ago

Any updates on this branch? Will it be ready for review this weekend?

3MKJOE58 commented 1 year ago

Code: ✅

Scripts have comments that explain the code. Variable names follow guidelines.

Functionality

It is possible to rotate the camera while right clicking. which seems to work ok currently but I have a couple suggestions to possibly improve this.

Improvements

  • Currently the mouse rotates only up and down. I think the feature would work better if there was more control over rotating. Not sure how it would be implemented currently though.
  • Also the camera jolts to look at the sky when you first right click, and then you can rotate down towards the planet but also more up and towards nothing. Is it possible to make the camera start at the current angle and have a slightly reduced limit so you can just look where the planet is?
  • The original request from Adon was to have the planet gameplay feel similar to the space gameplay. My interpretation of this would be that the camera kind of orbits the planet. and the player follows this positioning. This may be a very complicated feature and I may have seen it differently to others, so I don't mind if others disagree with this point.

Other Notes

  • You have two scripts: planetMaterialManager.cs and ApplyMaterial.cs in this branch which From what I understand this would solve the issue of the planet textures carrying through. However I cannot see if these have been implemented yet. Is this still a Work in Progress at this point?

they are scripts from former branch, forgot to delete them before pushing.

PBWiseman commented 1 year ago

I had a look through the branch. I like the changes to controlling it and clamping the rotation. Definitely improved. I did notice that it's possible to rotate the camera while paused which just needs an if timescale is 0 check. The camera also snaps up and then back down when you spawn in. The player rotating with the mouse moving side to side also doesn't seem to do anything since the rotation changes whenever you move in a direction anyway. Also, the camera is still closer than it was.

Would it be possible to basically copy the X camera movement to the Y movement to have a full range of camera freedom? Or does that not work?

Good changes overall! Feels much better!

3MKJOE58 commented 1 year ago

I had a look through the branch. I like the changes to controlling it and clamping the rotation. Definitely improved. I did notice that it's possible to rotate the camera while paused which just needs an if timescale is 0 check. The camera also snaps up and then back down when you spawn in. The player rotating with the mouse moving side to side also doesn't seem to do anything since the rotation changes whenever you move in a direction anyway. Also, the camera still feels closer than it was, but I am unsure if that is just a placebo.

Would it be possible to basically copy the X camera movement to the Y movement to have a full range of camera freedom? Or does that not work?

Good changes overall! Feels much better!

Have tried that before and it didn't work, it wont apply.